cmd/snap-confine: don't share /etc/nsswitch from host #3650

Merged
merged 1 commit into from Aug 4, 2017

Conversation

Projects
None yet
4 participants
Contributor

zyga commented Aug 2, 2017

This patch corrects name resolution errors on Arch where host's
/etc/nsswitch.conf contains references to modules not present in the
core snap. This is again one of the bugs originating from sharing all of
/etc blindly and then undoing the damage but for now it is easier to add
an exception than to undo this.

Signed-off-by: Zygmunt Krynicki me@zygoon.pl

cmd/snap-confine: don't share /etc/nsswitch from host
This patch corrects name resolution errors on Arch where host's
/etc/nsswitch.conf contains references to modules not present in the
core snap. This is again one of the bugs originating from sharing all of
/etc blindly and then undoing the damage but for now it is easier to add
an exception than to undo this.

Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>

Codecov Report

Merging #3650 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3650      +/-   ##
=========================================
+ Coverage    75.2%   75.2%   +<.01%     
=========================================
  Files         387     387              
  Lines       33452   33452              
=========================================
+ Hits        25157   25159       +2     
+ Misses       6482    6481       -1     
+ Partials     1813    1812       -1
Impacted Files Coverage Δ
cmd/snap/cmd_aliases.go 93.33% <0%> (-1.67%) ⬇️
overlord/snapstate/snapstate.go 80.46% <0%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3df03f9...22f2a56. Read the comment docs.

+1

@zyga zyga merged commit 8880f59 into snapcore:master Aug 4, 2017

6 of 7 checks passed

yakkety-amd64 autopkgtest finished (failure)
Details
artful-amd64 autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details

@zyga zyga deleted the zyga:fix/unshare-nsswitch branch Aug 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment