interfaces: convert broadcom-asic-control to common iface #3662

Merged
merged 1 commit into from Aug 7, 2017

Conversation

Projects
None yet
4 participants
Contributor

zyga commented Aug 4, 2017

This patch uses the improved common interface to cut the amount of
boilerplate code that needs to exist in the builtin interfaces packae.

Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com

interfaces: convert broadcom-asic-control to common iface
This patch uses the improved common interface to cut the amount of
boilerplate code that needs to exist in the builtin interfaces packae.

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>

Codecov Report

Merging #3662 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3662      +/-   ##
==========================================
- Coverage   75.16%   75.16%   -0.01%     
==========================================
  Files         388      388              
  Lines       33655    33633      -22     
==========================================
- Hits        25298    25280      -18     
+ Misses       6538     6535       -3     
+ Partials     1819     1818       -1
Impacted Files Coverage Δ
interfaces/builtin/broadcom_asic_control.go 100% <100%> (+8.82%) ⬆️
cmd/snap/cmd_aliases.go 93.33% <0%> (-1.67%) ⬇️
interfaces/builtin/common.go 65.57% <0%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e9fb9...11d8d64. Read the comment docs.

mvo5 approved these changes Aug 7, 2017

Whats not to like about when things get easier :) Will need a @jdstrand review as well though.

@zyga zyga requested a review from jdstrand Aug 7, 2017

@zyga zyga merged commit 0cb950e into snapcore:master Aug 7, 2017

5 of 7 checks passed

xenial-i386 autopkgtest finished (failure)
Details
yakkety-amd64 autopkgtest finished (failure)
Details
artful-amd64 autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details

@zyga zyga deleted the zyga:tweak/commonalize-broadcom-asic-control branch Aug 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment