interfaces: covert framebuffer to commonInterface

[zyga]

It used to be commonInterface but then changed to a custom one so that
udev snippets could be handled. Then those snippets were disabled
because of the bug with udev tagging breaking interfaces not using it
properly. Since this is all being fixed and udev taggning is supported
by commonInterface let's simplify this code.

Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com

[adglkh]

Thanks for this. LGTM.
Would you mind to fine-tune the framebuffer_test.go just like you did for avahi_control_test.go to be consistent with a few interfaces we tweaked in these days?
E.g.
*. Utilize MockPlug/MockSlot to setup slot and plug.
*. Test each security backend block by block
*. Improve the test case by adding TestStaticInfo, TestAutoConnect,

Thanks again.

[zyga]

Yes, I'm doing that now :-)

[zyga]

Tests added, in one bigger branch :-)

[adglkh]

LGTM. +1

[codecov-io]

Codecov Report

Merging #3696 into master will increase coverage by 0.25%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3696      +/-   ##
==========================================
+ Coverage   75.32%   75.57%   +0.25%     
==========================================
  Files         389      391       +2     
  Lines       33666    33805     +139     
==========================================
+ Hits        25359    25549     +190     
+ Misses       6489     6438      -51     
  Partials     1818     1818

Impacted Files	Coverage Δ
interfaces/builtin/framebuffer.go	100% <100%> (+72.72%)	⬆️
interfaces/builtin/wayland.go	100% <0%> (ø)
interfaces/builtin/spi.go	86.95% <0%> (ø)
cmd/snap/cmd_aliases.go	95% <0%> (+1.66%)	⬆️
wrappers/desktop.go	75.96% <0%> (+7.72%)	⬆️
interfaces/builtin/kvm.go	71.42% <0%> (+9.89%)	⬆️
wrappers/services.go	87.61% <0%> (+10.91%)	⬆️
interfaces/builtin/joystick.go	60.71% <0%> (+15.71%)	⬆️
overlord/snapstate/backend/link.go	64.86% <0%> (+20.65%)	⬆️
wrappers/binaries.go	78.12% <0%> (+25.49%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66c1a02...954da4d. Read the comment docs.