cmd/snap-confine: set _FILE_OFFSET_BITS to 64 #3699

Merged
merged 1 commit into from Aug 9, 2017

Conversation

Projects
None yet
4 participants
Contributor

zyga commented Aug 9, 2017

This fixes build issues on some 32bit systems which previously choked on
xfs header files and size of some structures.

Signed-off-by: Zygmunt Krynicki me@zygoon.pl

cmd/snap-confine: set _FILE_OFFSET_BITS to 64
This fixes build issues on some 32bit systems which previously choked on
xfs header files and size of some structures.

Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>

@zyga zyga requested a review from mvo5 Aug 9, 2017

@zyga zyga added this to the 2.27 milestone Aug 9, 2017

Collaborator

mvo5 commented Aug 9, 2017

👍

mvo5 approved these changes Aug 9, 2017

@zyga zyga merged commit cd10eca into snapcore:master Aug 9, 2017

3 of 7 checks passed

xenial-ppc64el autopkgtest finished (failure)
Details
xenial-i386 autopkgtest running
Details
yakkety-amd64 autopkgtest running
Details
zesty-amd64 autopkgtest running
Details
artful-amd64 autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details

@zyga zyga deleted the zyga:fixup/snap-seccomp-x86 branch Aug 9, 2017

Codecov Report

Merging #3699 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3699      +/-   ##
==========================================
+ Coverage   75.44%   75.48%   +0.03%     
==========================================
  Files         391      391              
  Lines       33745    33758      +13     
==========================================
+ Hits        25460    25481      +21     
+ Misses       6471     6464       -7     
+ Partials     1814     1813       -1
Impacted Files Coverage Δ
cmd/snap-seccomp/main.go 49.79% <ø> (ø) ⬆️
cmd/snap/cmd_aliases.go 93.33% <0%> (-1.67%) ⬇️
overlord/ifacestate/helpers.go 63% <0%> (+0.66%) ⬆️
interfaces/sorting.go 100% <0%> (+1.28%) ⬆️
wrappers/binaries.go 79.31% <0%> (+10.34%) ⬆️
interfaces/builtin/joystick.go 60.71% <0%> (+15.71%) ⬆️
interfaces/builtin/framebuffer.go 44.73% <0%> (+17.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 300f3a6...8621e3c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment