overlord: rely on more conservative ensure interval #3716

Merged
merged 1 commit into from Aug 13, 2017

Conversation

Projects
None yet
2 participants
Contributor

zyga commented Aug 11, 2017

On openSUSE tumbleweed running Linux 4.11.8 and golang 1.8.3 the
observed latency between subsequent calls to Ensure in
overlordSuite.EnsureLoopPrune is on the order of ~500ms versus ~50ms on
of the same binary running on top of Ubuntu Artful with Linux 4.11.0 and
golang 1.8.1. This makes the test fail as the sequence of evens it
widely different and things just don't happen in time.

As a workaround, before the root issue is understood better, use a more
conservative prune interval of 200ms (up from 20ms) which makes this test
pass each time.

Signed-off-by: Zygmunt Krynicki me@zygoon.pl

@zyga zyga added this to the 2.27 milestone Aug 11, 2017

@zyga zyga changed the title from overlord: rely on more conservative ensure inteval to overlord: rely on more conservative ensure interval Aug 11, 2017

codecov-io commented Aug 11, 2017

Codecov Report

Merging #3716 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3716      +/-   ##
==========================================
- Coverage   75.65%   75.65%   -0.01%     
==========================================
  Files         391      391              
  Lines       33849    33849              
==========================================
- Hits        25609    25607       -2     
- Misses       6418     6420       +2     
  Partials     1822     1822
Impacted Files Coverage Δ
wrappers/binaries.go 68.96% <0%> (-10.35%) ⬇️
cmd/snap/cmd_aliases.go 93.33% <0%> (-1.67%) ⬇️
interfaces/sorting.go 98.71% <0%> (-1.29%) ⬇️
overlord/ifacestate/helpers.go 62.33% <0%> (ø) ⬆️
overlord/snapstate/snapstate.go 80.72% <0%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 506d333...7aabe17. Read the comment docs.

overlord: rely on more conservative ensure interval
On openSUSE tumbleweed running Linux 4.11.8 and golang 1.8.3 the
observed latency between subsequent calls to Ensure in
overlordSuite.EnsureLoopPrune is on the order of ~500ms versus ~50ms on
of the same binary running on top of Ubuntu Artful with Linux 4.11.0 and
golang 1.8.1. This makes the test fail as the sequence of evens it
widely different and things just don't happen in time.

As a workaround, before the root issue is understood better, use a more
conservative prune interval of 200ms (up from 20ms) which makes this test
pass each time.

Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>

@zyga zyga merged commit 2a578cd into snapcore:master Aug 13, 2017

6 of 7 checks passed

xenial-amd64 autopkgtest finished (failure)
Details
artful-amd64 autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
yakkety-amd64 autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details

@zyga zyga deleted the zyga:fix/conservative-ensure-timings branch Aug 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment