Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
overlord: rely on more conservative ensure interval #3716
Conversation
zyga
added this to the 2.27 milestone
Aug 11, 2017
zyga
changed the title from
overlord: rely on more conservative ensure inteval
to
overlord: rely on more conservative ensure interval
Aug 11, 2017
codecov-io
commented
Aug 11, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #3716 +/- ##
==========================================
- Coverage 75.65% 75.65% -0.01%
==========================================
Files 391 391
Lines 33849 33849
==========================================
- Hits 25609 25607 -2
- Misses 6418 6420 +2
Partials 1822 1822
Continue to review full report at Codecov.
|
zyga
merged commit 2a578cd
into
snapcore:master
Aug 13, 2017
6 of 7 checks passed
xenial-amd64
autopkgtest finished (failure)
Details
artful-amd64
autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
xenial-i386
autopkgtest finished (success)
Details
xenial-ppc64el
autopkgtest finished (success)
Details
yakkety-amd64
autopkgtest finished (success)
Details
zesty-amd64
autopkgtest finished (success)
Details
zyga
deleted the
zyga:fix/conservative-ensure-timings
branch
Aug 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
zyga commentedAug 11, 2017
•
Edited 1 time
-
zyga
Aug 11, 2017
On openSUSE tumbleweed running Linux 4.11.8 and golang 1.8.3 the
observed latency between subsequent calls to Ensure in
overlordSuite.EnsureLoopPrune is on the order of ~500ms versus ~50ms on
of the same binary running on top of Ubuntu Artful with Linux 4.11.0 and
golang 1.8.1. This makes the test fail as the sequence of evens it
widely different and things just don't happen in time.
As a workaround, before the root issue is understood better, use a more
conservative prune interval of 200ms (up from 20ms) which makes this test
pass each time.
Signed-off-by: Zygmunt Krynicki me@zygoon.pl