interfaces: backport broadcom-asic-control interface (2.27)

[zyga]

This patch backports the new interface to the 2.27.x release branch per
request of Canonical Commercial Engineering team.

Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com

[codecov-io]

Codecov Report

Merging #3726 into release/2.27 will increase coverage by <.01%.
The diff coverage is 82.92%.

@@               Coverage Diff                @@
##           release/2.27    #3726      +/-   ##
================================================
+ Coverage         74.86%   74.87%   +<.01%     
================================================
  Files               381      382       +1     
  Lines             32941    32982      +41     
================================================
+ Hits              24662    24694      +32     
- Misses             6483     6489       +6     
- Partials           1796     1799       +3

Impacted Files	Coverage Δ
interfaces/builtin/broadcom_asic_control.go	82.92% <82.92%> (ø)
interfaces/sorting.go	94.28% <0%> (-2.86%)	⬇️
cmd/snap/cmd_aliases.go	93.33% <0%> (-1.67%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f981c7...7d0262f. Read the comment docs.

[mvo5]

LTGTM

[jdstrand]

It's a little weird that the 2.27 backport has functions in this order: apparmor, autoconnect, kmod, udev but master is: apparmor, udev, kmod, autoconnect. The code is correct, so no problem; just a bit harder to verify the patch.

[zyga]

Ah, sorry, I think the weird order was because that is how they look like in common.go (perhaps, not sure). I'll check and fix that if so