Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interfaces/many: updates based on chromium and mrrescue denials #3751

Merged
merged 3 commits into from Aug 17, 2017

Conversation

Projects
None yet
3 participants
@jdstrand
Copy link
Contributor

commented Aug 16, 2017

  • interfaces/alsa,pulseaudio: allow read on udev data for sound
  • interfaces/optical-drive: read access to udev data for /dev/scd*
  • interfaces/browser-support: read on /proc/vmstat and misc udev data
@codecov-io

This comment has been minimized.

Copy link

commented Aug 16, 2017

Codecov Report

Merging #3751 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3751      +/-   ##
==========================================
- Coverage    75.8%   75.79%   -0.02%     
==========================================
  Files         399      399              
  Lines       34294    34294              
==========================================
- Hits        25997    25993       -4     
- Misses       6448     6451       +3     
- Partials     1849     1850       +1
Impacted Files Coverage Δ
interfaces/builtin/optical_drive.go 100% <ø> (ø) ⬆️
interfaces/builtin/browser_support.go 76.31% <ø> (ø) ⬆️
interfaces/builtin/alsa.go 100% <ø> (ø) ⬆️
interfaces/builtin/pulseaudio.go 37.03% <ø> (ø) ⬆️
wrappers/binaries.go 72.72% <0%> (-6.82%) ⬇️
cmd/snap/cmd_aliases.go 93.33% <0%> (-1.67%) ⬇️
overlord/ifacestate/helpers.go 62.33% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9267399...b399f4d. Read the comment docs.

@zyga

zyga approved these changes Aug 17, 2017

Copy link
Contributor

left a comment

LGTM

@zyga zyga merged commit b151bc3 into snapcore:master Aug 17, 2017

5 of 7 checks passed

xenial-amd64 autopkgtest finished (failure)
Details
yakkety-amd64 autopkgtest finished (failure)
Details
artful-amd64 autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details
@jdstrand

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2017

Thanks!

@mvo5 - if you are going to do a 2.27.3, please consider adding this PR (since it addresses an issue in the new chromium snap (ie, this is not for a regression)).

@jdstrand jdstrand deleted the jdstrand:policy-updates-xxviii branch Aug 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.