add spread test for wayland

[jdstrand]

No description provided.

[codecov-io]

Codecov Report

Merging #3759 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3759      +/-   ##
==========================================
+ Coverage   75.81%   75.81%   +<.01%     
==========================================
  Files         402      402              
  Lines       34783    34793      +10     
==========================================
+ Hits        26371    26380       +9     
- Misses       6539     6540       +1     
  Partials     1873     1873

Impacted Files	Coverage Δ
cmd/snap/cmd_aliases.go	93.33% <0%> (-1.67%)	⬇️
overlord/snapstate/snapstate.go	80.4% <0%> (-0.27%)	⬇️
overlord/ifacestate/helpers.go	62.33% <0%> (ø)	⬆️
interfaces/sorting.go	98.71% <0%> (ø)	⬆️
dirs/dirs.go	97.91% <0%> (+0.24%)	⬆️
wrappers/binaries.go	79.54% <0%> (+6.81%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 789c8b4...729d2c9. Read the comment docs.

[sergiocazzolato]

Minor comments inline

[sergiocazzolato]

This should go in the pkgdb.sh script, we started to install all the dependencies in the project preparation a time ago.

[jdstrand]

Done

[sergiocazzolato]

this should not be needed.

[jdstrand]

Done

[jdstrand]

@sergiocazzolato - I made the requested changes. This should be ready for another review.

[jdstrand]

Note the zesty failure is unrelated:

Cloning into '/tmp/go/src/golang.org/x/net'...
fatal: unable to access 'https://go.googlesource.com/net/': gnutls_handshake() failed: The TLS connection was non-properly terminated.
package golang.org/x/net/context: exit status 128
autopkgtest [21:00:53]: test integrationtests: -----------------------]
autopkgtest [21:00:53]: test integrationtests:  - - - - - - - - - - results - - - - - - - - - -
integrationtests     FAIL non-zero exit status 1
autopkgtest [21:00:53]: @@@@@@@@@@@@@@@@@@@@ summary
integrationtests     FAIL non-zero exit status 1
Exit request sent.

[jdstrand]

@sergiocazzolato - can you take another look at this? It is passing and I addressed all your feedback.

[sergiocazzolato]

This could be removed

[jdstrand]

Done

[sergiocazzolato]

LGMT, thanks for the test!

[jdstrand]

Hmm, now the zesty-amd64 autopkgtest failed for this test, so I'll need to look at that.

[mvo5]

Looks good, thanks for writing this test! Some small comments inside for your consideration.

[mvo5]

Our usual pattern for spread helpers is: test-snapd-*, i.e. test-snapd-wayland.

[jdstrand]

Done

[mvo5]

I think we want this also in restore: to ensure if anything fails during the test we do proper cleanup.

[jdstrand]

Note the comment below:

# If this is in 'restore', it hangs the test

[jdstrand]

I've decided to add the killall to restore but leave it at the end of execute to prevent the hang in the normal case.

[jdstrand]

@mvo, ok, comments addressed. Thanks for the review :)

[mvo5]

One more thing - is test-snapd-wayland packaged somewhere? If there is a snapcraft.yaml for it, we should add it to tests/lib/snaps or if not add a comment where the git tree for this is.

[jdstrand]

Yes, lp:~jdstrand/+git/test-snapd-wayland. I listed it in the description of the snap:

$ snap info test-snapd-wayland
name:      test-snapd-wayland
summary:   "Basic wayland test snap"
publisher: jdstrand
description: |
  Basic wayland test snap
  lp:~jdstrand/+git/test-snapd-wayland
...