cmd/snap-confine: genearlize apparmor profile for various lib layout #3789

Merged
merged 1 commit into from Aug 23, 2017

Conversation

Projects
None yet
3 participants
Contributor

zyga commented Aug 23, 2017

Depending on the distribution at hand we the conceptual "/lib" may be
at /lib or /usr/lib, the "lib" directory may be spelled
lib, lib32, lib64 or even libx32. It may be optionally followed by a
multiarch suffix. This patch applies those rules to all the shared
libraries we need to map and read.

Signed-off-by: Zygmunt Krynicki me@zygoon.pl

@zyga zyga requested a review from jdstrand Aug 23, 2017

- /usr/lib/@{multiarch}/libseccomp.so* mr,
- /lib/@{multiarch}/libseccomp.so* mr,
+ /{,usr/}lib{,32,64,x32}/{,@{multiarch}/}libapparmor.so* mr,
+ /{,usr/}lib{,32,64,x32}/{,@{multiarch}/}libcgmanager.so* mr,
@jdstrand

jdstrand Aug 23, 2017

Contributor

You dropped libdl.

@zyga

zyga Aug 23, 2017

Contributor

Corrected

cmd/snap-confine: genearlize apparmor profile for various lib layout
Depending on the distribution at hand we the conceptual "/lib" may be
at /lib or /usr/lib, the "lib" directory may be spelled
lib, lib32, lib64 or even libx32. It may be optionally followed by a
multiarch suffix. This patch applies those rules to all the shared
libraries we need to map and read.

Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>

Assuming the testsuite passes, approving.

Codecov Report

Merging #3789 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3789      +/-   ##
==========================================
- Coverage   75.81%   75.81%   -0.01%     
==========================================
  Files         402      402              
  Lines       34741    34745       +4     
==========================================
+ Hits        26340    26341       +1     
- Misses       6527     6529       +2     
- Partials     1874     1875       +1
Impacted Files Coverage Δ
corecfg/powerbtn.go 70.73% <0%> (-4.95%) ⬇️
interfaces/builtin/core_support.go 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 947c2d4...6307131. Read the comment docs.

@zyga zyga merged commit 2101bac into snapcore:master Aug 23, 2017

6 of 7 checks passed

artful-amd64 autopkgtest running
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
yakkety-amd64 autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details

@zyga zyga deleted the zyga:tweak/generic-snap-confine-aa-profile branch Aug 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment