Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
interfaces/apparmor: add missing call to dirs.SetRootDir #3813
Conversation
codecov-io
commented
Aug 26, 2017
Codecov Report
@@ Coverage Diff @@
## master #3813 +/- ##
==========================================
+ Coverage 75.81% 75.82% +<.01%
==========================================
Files 402 402
Lines 34793 34793
==========================================
+ Hits 26380 26382 +2
+ Misses 6540 6538 -2
Partials 1873 1873
Continue to review full report at Codecov.
|
zyga
merged commit a2d361b
into
snapcore:master
Aug 26, 2017
7 checks passed
artful-amd64
autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
xenial-amd64
autopkgtest finished (success)
Details
xenial-i386
autopkgtest finished (success)
Details
xenial-ppc64el
autopkgtest finished (success)
Details
yakkety-amd64
autopkgtest finished (success)
Details
zesty-amd64
autopkgtest finished (success)
Details
zyga
deleted the
zyga:fix/add-missing-mock
branch
Aug 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
zyga commentedAug 26, 2017
This patch corrects a test that was failing on openSUSE. On Ubuntu it
was passing by accident because /var/cache/apparmor/$something did not
exist (the code treats file-not-found as an OK condition). On openSUSE
the permissions prevent non-root users from traversing
/var/cache/apparmor so the test failed with permission error.
In both cases what was missing was a call to dirs.SetRootDir(), to
isolate the test from the real system.
Signed-off-by: Zygmunt Krynicki me@zygoon.pl