Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
interfaces: fix network-manager plug #3818
Conversation
| @@ -459,6 +464,11 @@ func (iface *networkManagerInterface) SecCompPermanentSlot(spec *seccomp.Specifi | ||
| return nil | ||
| } | ||
| +func (iface *networkManagerInterface) SecCompPermanentPlug(spec *seccomp.Specification, plug *interfaces.Plug) error { |
mvo5
added some commits
Aug 28, 2017
mvo5
requested a review
from
jdstrand
Aug 28, 2017
zyga
added this to the 2.27 milestone
Aug 28, 2017
codecov-io
commented
Aug 28, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #3818 +/- ##
==========================================
- Coverage 75.86% 75.84% -0.03%
==========================================
Files 403 403
Lines 34835 34907 +72
==========================================
+ Hits 26427 26474 +47
- Misses 6535 6555 +20
- Partials 1873 1878 +5
Continue to review full report at Codecov.
|
|
We will need to squash merge this to make the 2.27 cherry pick simpler. |
pedronis
changed the title from
interfaces: fix network-manger plug
to
interfaces: fix network-manager plug
Aug 28, 2017
zyga
merged commit ac6b754
into
snapcore:master
Aug 29, 2017
5 of 7 checks passed
xenial-ppc64el
autopkgtest finished (failure)
Details
yakkety-amd64
autopkgtest finished (failure)
Details
artful-amd64
autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
xenial-amd64
autopkgtest finished (success)
Details
xenial-i386
autopkgtest finished (success)
Details
zesty-amd64
autopkgtest finished (success)
Details
|
LGTM, +1 |
added a commit
that referenced
this pull request
Aug 29, 2017
niemeyer
removed the request for review
from
jdstrand
Aug 31, 2017
|
@jdstrand Sending the +1 and the change requests (or even relevant comments) with the actual review feature of GH makes your review tracked both in the summary at the right above, and also in our review board. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mvo5 commentedAug 28, 2017
•
Edited 1 time
-
mvo5
Aug 29, 2017
Add networkManagerPermanentPlugSecComp that adds socket AF_NETLINK - KOBJECT_UEVENT to unbreak nmcli.
We should squash-merge this and then cherry-pick it for 2.27.