interfaces/opengl: use == to compare, not = #3833

Merged
merged 1 commit into from Aug 31, 2017

Conversation

Projects
None yet
4 participants
Contributor

zyga commented Aug 31, 2017

This fixes an invalid udev rule where SUBSYSTEM was incorrectly compared
to the value "drm" using a single equals character, indicating
assignment. This is not what was meant to happen.

Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com

Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?

interfaces/opengl: use == to compare, not =
This fixes an invalid udev rule where SUBSYSTEM was incorrectly compared
to the value "drm" using a single equals character, indicating
assignment. This is not what was meant to happen.

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>

@zyga zyga requested a review from jdstrand Aug 31, 2017

@zyga zyga added this to the 2.28 milestone Aug 31, 2017

@zyga zyga added the Critical label Aug 31, 2017

mvo5 approved these changes Aug 31, 2017

Contributor

zyga commented Aug 31, 2017

@mvo5 - this is only affecting master, 2.27 is correct.

LGTM

Codecov Report

Merging #3833 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3833      +/-   ##
==========================================
+ Coverage   75.74%   75.74%   +<.01%     
==========================================
  Files         409      409              
  Lines       35388    35388              
==========================================
+ Hits        26804    26805       +1     
+ Misses       6688     6687       -1     
  Partials     1896     1896
Impacted Files Coverage Δ
interfaces/builtin/opengl.go 100% <ø> (ø) ⬆️
cmd/snap/cmd_aliases.go 95% <0%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73bbe43...5de4eb4. Read the comment docs.

@mvo5 mvo5 merged commit 6d8d625 into snapcore:master Aug 31, 2017

6 of 7 checks passed

xenial-ppc64el autopkgtest finished (failure)
Details
artful-amd64 autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-i386 autopkgtest finished (success)
Details
yakkety-amd64 autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details

@zyga zyga deleted the zyga:fix/opengl-subsystem branch Sep 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment