Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/snap-seccomp/main_test.go: add one more syscall for arm64 #3834

Merged

Conversation

jdstrand
Copy link

@jdstrand jdstrand commented Aug 31, 2017

I tested this locally on dragonboard in classic by running:

$ go build -v github.com/snapcore/snapd/... && go test -v github.com/snapcore/snapd/cmd/snap-seccomp
...
=== RUN   Test
OK: 11 passed
--- PASS: Test (355.58s)
PASS
ok  	github.com/snapcore/snapd/cmd/snap-seccomp	355.600s

Copy link
Collaborator

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-io
Copy link

Codecov Report

Merging #3834 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3834   +/-   ##
=======================================
  Coverage   75.74%   75.74%           
=======================================
  Files         409      409           
  Lines       35388    35388           
=======================================
  Hits        26804    26804           
  Misses       6688     6688           
  Partials     1896     1896
Impacted Files Coverage Δ
interfaces/sorting.go 98.71% <0%> (-1.29%) ⬇️
overlord/ifacestate/helpers.go 62.33% <0%> (ø) ⬆️
cmd/snap/cmd_aliases.go 95% <0%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b346ee...d662180. Read the comment docs.

@jdstrand
Copy link
Author

Two approvals, thanks! Merging.

@jdstrand jdstrand merged commit a88be13 into snapcore:master Aug 31, 2017
@jdstrand jdstrand deleted the fix-seccomp-on-armhf-arm64-part-ii branch September 1, 2017 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants