Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
packaging/fedora: Ensure vendor/ is empty for builds and fix spec to build current master #3859
Conversation
Some checks were not successful
|
Note that I expect spread to fail at this point, and I need it to fail because I know the spec is outdated vs what's changed. |
Some checks were not successful
Conan-Kudo
changed the title from
packaging/fedora: Ensure vendor/ is empty for builds.
to
packaging/fedora: Ensure vendor/ is empty for builds and fix spec to build current master
Sep 6, 2017
Some checks were not successful
|
I still expect spread to fail on Fedora, because RH#1488747 needs to be addressed first. |
zyga
approved these changes
Sep 7, 2017
+1 with a suggestion that would allow us to land this faster.
| @@ -98,6 +99,7 @@ BuildRequires: golang(golang.org/x/crypto/ssh/terminal) | ||
| BuildRequires: golang(golang.org/x/net/context) | ||
| BuildRequires: golang(golang.org/x/net/context/ctxhttp) | ||
| BuildRequires: golang(gopkg.in/check.v1) | ||
| +BuildRequires: golang(gopkg.in/cheggaaa/pb.v1) |
zyga
Sep 7, 2017
Contributor
We could depend on it and then do some symlinks at the right spot to unblock the build and land it for now.
Conan-Kudo
Sep 10, 2017
Contributor
I implemented this, but I'm extremely unhappy that this situation even happened to begin with.
codecov-io
commented
Sep 10, 2017
•
Edited 1 time
-
codecov-io
Sep 10, 2017
-
Sep 10, 2017
Codecov Report
@@ Coverage Diff @@
## master #3859 +/- ##
=========================================
+ Coverage 75.89% 75.9% +<.01%
=========================================
Files 416 416
Lines 35988 35988
=========================================
+ Hits 27312 27315 +3
+ Misses 6755 6753 -2
+ Partials 1921 1920 -1
Continue to review full report at Codecov.
|
All checks have passed
Conan-Kudo commentedSep 6, 2017
•
Edited 1 time
-
Conan-Kudo
Sep 6, 2017
DO NOT SQUASH MERGE THIS
For Fedora, we're building with unbundled components, but it seems that vendored stuff is leaking into spread tests and other things.
So let's just enforce that we build the right way so that we don't get misled by spread tests.
In addition, some basic fixes to the spec file so that it matches reality have been done, too.
Unfortunately, because CI checkmarks rule over everything and this needs to be in 2.28 (because the build is broken), a temporary hack has been pushed to fix the build too.
Signed-off-by: Neal Gompa ngompa13@gmail.com