hooks: rename refresh hook to post-refresh #3969

Merged
merged 1 commit into from Sep 27, 2017

Conversation

Projects
None yet
5 participants
Contributor

stolowski commented Sep 26, 2017

It turned out after-refresh wouldn't be consistent with existing terminology (including snapcraft).

@stolowski stolowski added this to the 2.28 milestone Sep 26, 2017

Change lgtm

mvo5 approved these changes Sep 26, 2017

zyga approved these changes Sep 26, 2017

Third time's the charm

Codecov Report

Merging #3969 into master will not change coverage.
The diff coverage is 44.44%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3969   +/-   ##
=======================================
  Coverage   75.96%   75.96%           
=======================================
  Files         423      423           
  Lines       36525    36525           
=======================================
  Hits        27748    27748           
  Misses       6836     6836           
  Partials     1941     1941
Impacted Files Coverage Δ
snap/hooktypes.go 100% <ø> (ø) ⬆️
overlord/hookstate/hookmgr.go 66.02% <100%> (ø) ⬆️
overlord/snapstate/snapstate.go 80.09% <33.33%> (ø) ⬆️
overlord/hookstate/hooks.go 15.68% <40%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41a23c8...94eeba1. Read the comment docs.

@zyga zyga merged commit 1611ac4 into snapcore:master Sep 27, 2017

7 checks passed

artful-amd64 autopkgtest finished (success)
Details
artful-i386 autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment