snap-confine: update apparmor rules for fedora based base snaps #3979

Merged
merged 2 commits into from Sep 27, 2017

Conversation

Projects
None yet
5 participants
Collaborator

mvo5 commented Sep 27, 2017

On fedora /bin,/lib,/sbin are just symlinks to /usr/{bin,lib,sbin} so we need to update our apparmor rules for fedora based base snaps.

@mvo5 mvo5 added this to the 2.28 milestone Sep 27, 2017

Personally I prefer {,/usr} over {/usr,}, but no need to change if you aren't making other changes. Approved.

@mvo5 mvo5 requested a review from jdstrand Sep 27, 2017

zyga approved these changes Sep 27, 2017

+1

Contributor

Conan-Kudo commented Sep 27, 2017

@mvo5 @jdstrand already approved this PR. And it looks good to merge to me as well.

codecov-io commented Sep 27, 2017

Codecov Report

Merging #3979 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3979   +/-   ##
=======================================
  Coverage   75.97%   75.97%           
=======================================
  Files         423      423           
  Lines       36505    36505           
=======================================
  Hits        27734    27734           
  Misses       6833     6833           
  Partials     1938     1938

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d7d79c...bdb55ed. Read the comment docs.

@mvo5 mvo5 merged commit 6b9f8f1 into snapcore:master Sep 27, 2017

5 of 7 checks passed

artful-amd64 autopkgtest running
Details
artful-i386 autopkgtest running
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment