interfaces/lxd: lxd slot implementation can also be an app snap #4004

Merged
merged 1 commit into from Oct 5, 2017

Conversation

Projects
None yet
5 participants
Contributor

jdstrand commented Oct 4, 2017

The lxd snap has existed for a while, but the interface mistakenly used 'reservedForOS: true'.

@jdstrand jdstrand requested a review from stolowski Oct 4, 2017

chipaca approved these changes Oct 4, 2017

oops

Codecov Report

Merging #4004 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4004      +/-   ##
==========================================
+ Coverage   75.71%   75.71%   +<.01%     
==========================================
  Files         424      424              
  Lines       36609    36608       -1     
==========================================
+ Hits        27718    27719       +1     
+ Misses       6945     6943       -2     
  Partials     1946     1946
Impacted Files Coverage Δ
interfaces/builtin/lxd.go 100% <ø> (ø) ⬆️
overlord/ifacestate/helpers.go 63% <0%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e36fb9...042f9d0. Read the comment docs.

zyga approved these changes Oct 5, 2017

LGTM

@zyga zyga merged commit f3ff7bf into snapcore:master Oct 5, 2017

7 checks passed

artful-amd64 autopkgtest finished (success)
Details
artful-i386 autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details
Contributor

stolowski commented Oct 5, 2017

Thanks!

@jdstrand jdstrand deleted the jdstrand:lxd-is-an-app-too branch Nov 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment