Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
interfaces/opengl: don't udev tag nvidia devices and use snap-confine instead (2.28) #4022
Conversation
jdstrand
and others
added some commits
Sep 18, 2017
Some checks were not successful
All checks have passed
Some checks were not successful
codecov-io
commented
Oct 11, 2017
•
Edited 1 time
-
codecov-io
Oct 11, 2017
-
Oct 11, 2017
Codecov Report
@@ Coverage Diff @@
## master #4022 +/- ##
=======================================
Coverage 75.88% 75.88%
=======================================
Files 431 431
Lines 36915 36915
=======================================
Hits 28014 28014
Misses 6948 6948
Partials 1953 1953
Continue to review full report at Codecov.
|
Some checks were not successful
jdstrand
approved these changes
Oct 11, 2017
I'm marking Approve for now. Your rules are fine but I suggest you use the ones I mentioned.
I'm surprised that 2.28 didn't have the nvidia code changes-- I specifically did the PR with priority so it would be in 2.28. I guess 2.28 branched before the PR. Darn
| + /sys/module/nvidia_uvm/uevent r, | ||
| + /sys/module/nvidia_modeset/uevent r, | ||
| + /sys/module/nvidia_drm/uevent r, | ||
| + /sys/module/nvidia/uevent r, |
jdstrand
Oct 11, 2017
Contributor
I suggest for future-proofing:
/sys/module/nvidia/* r,
/sys/**/nvidia*/uevent r,
jdstrand
Oct 11, 2017
Contributor
Let's make this even better:
/sys/module/nvidia{,_*}/* r,
/sys/**/drivers/nvidia{,_*}/* r,
zyga
added some commits
Oct 11, 2017
Some checks were not successful
All checks have passed
mvo5
changed the base branch from
master
to
release/2.28
Oct 11, 2017
| @@ -249,6 +249,12 @@ | ||
| # nvidia handling, glob needs /usr/** and the launcher must be | ||
| # able to bind mount the nvidia dir | ||
| /sys/module/nvidia/version r, | ||
| + /sys/**/drivers/nvidia{,_*}/* r, | ||
| + /sys/**/nvidia*/uevent r, | ||
| + /sys/module/nvidia{,_*}/* r, |
jdstrand
Oct 11, 2017
Contributor
This covers the first rule (/sys/module/nvidia/version r,) so you can omit the first rule.
zyga
Oct 11, 2017
Contributor
Let's remove this in the post-mortem move and let mvo release the point release.
mvo5 commentedOct 11, 2017
•
Edited 1 time
-
mvo5
Oct 11, 2017
This should fix the regression in the opengl interface with the nvidia driver.
This is the 2.28 version of #3938