Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
dbus: ensure io.snapcraft.Launcher.service is created on re-exec #4034
Conversation
Some checks were not successful
mvo5
added this to the 2.28 milestone
Oct 12, 2017
| +// `snap us erd` instance on re-exec | ||
| +func setupDbusServiceForUserd(snapInfo *snap.Info) error { | ||
| + coreRoot := snapInfo.MountDir() | ||
| + dst := "/usr/share/dbus-1/services/io.snapcraft.Launcher.service" |
| @@ -57,6 +71,13 @@ func (b *Backend) Setup(snapInfo *snap.Info, opts interfaces.ConfinementOptions, | ||
| return fmt.Errorf("cannot obtain dbus specification for snap %q: %s", snapName, err) | ||
| } | ||
| + // core on classic is special | ||
| + if snapName == "core" && release.OnClassic && !release.ReleaseInfo.ForceDevMode() { |
chipaca
Oct 12, 2017
Member
do you really mean snapName == "core" and not snapInfo.Type == snap.TypeCore?
mvo5
Oct 12, 2017
Collaborator
Hm, hm, a good question. I would say "core" is ok here because only on "core" we know that this parth exists.
zyga
Oct 12, 2017
Contributor
Why is the ForceDevMode check there? I think this is "are we supporting reexec" not "force devmode"
| @@ -46,6 +49,17 @@ func (b *Backend) Name() interfaces.SecuritySystem { | ||
| return "dbus" | ||
| } | ||
| +// setupDbusServiceForUserd will setup the service file for the new | ||
| +// `snap us erd` instance on re-exec |
| + // core on classic is special | ||
| + if snapName == "core" && release.OnClassic && !release.ReleaseInfo.ForceDevMode() { | ||
| + if err := setupDbusServiceForUserd(snapInfo); err != nil { | ||
| + logger.Noticef("cannot create host snap-confine apparmor configuration: %s", err) |
Some checks were not successful
continuous-integration/travis-ci/pr
— The Travis CI build could not complete due to an error
Some checks were not successful
codecov-io
commented
Oct 12, 2017
•
Edited 1 time
-
codecov-io
Oct 13, 2017
Edited 1 time
-
Oct 13, 2017
Codecov Report
@@ Coverage Diff @@
## master #4034 +/- ##
==========================================
- Coverage 75.88% 75.85% -0.03%
==========================================
Files 431 431
Lines 36915 36926 +11
==========================================
- Hits 28014 28012 -2
- Misses 6948 6960 +12
- Partials 1953 1954 +1
Continue to review full report at Codecov.
|
mvo5
added some commits
Oct 12, 2017
Some checks were not successful
All checks have passed
mvo5
merged commit e338a29
into
snapcore:master
Oct 13, 2017
1 of 7 checks passed
artful-amd64
autopkgtest running
Details
artful-i386
autopkgtest running
Details
xenial-amd64
autopkgtest running
Details
xenial-i386
autopkgtest running
Details
xenial-ppc64el
autopkgtest running
Details
zesty-amd64
autopkgtest running
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mvo5 commentedOct 12, 2017
For
snap userdto work we need the file:/usr/share/dbus-1/services/io.snapcraft.Launcher.service
It is part of the deb/rpm package. However if snapd is using
re-exec we need to ensure this file is created by the dbus
backend.
See https://forum.snapcraft.io/t/snapd-2-28-xdg-open-doesnt-work-for-electron-applications/2447/5