Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
tests: add new kernel refresh/revert test for spread-cron #4063
Conversation
Some checks were not successful
codecov-io
commented
Oct 20, 2017
•
Edited 4 times
-
codecov-io
Dec 20, 2017
-
codecov-io
Nov 20, 2017
-
codecov-io
Nov 20, 2017
-
codecov-io
Nov 17, 2017
-
Dec 20, 2017 -
Nov 20, 2017 -
Nov 20, 2017 -
Nov 17, 2017
Codecov Report
@@ Coverage Diff @@
## master #4063 +/- ##
==========================================
+ Coverage 75.95% 78.03% +2.07%
==========================================
Files 440 449 +9
Lines 38427 30907 -7520
==========================================
- Hits 29188 24118 -5070
+ Misses 7225 4776 -2449
+ Partials 2014 2013 -1
Continue to review full report at Codecov.
|
stolowski
approved these changes
Oct 25, 2017
Very nice! Two comments for your consideration before merging.
| + NEW_KERNEL_CHANNEL: edge | ||
| + | ||
| +restore: | | ||
| + rm -f prevBoot nextBoot |
stolowski
Oct 25, 2017
Contributor
We should probably also remove prevKernelSignature and nextKernelSignature?
| + snap install test-snapd-tools | ||
| + | ||
| +execute: | | ||
| + wait_core_post_boot() { |
stolowski
Oct 25, 2017
Contributor
Is it worth moving to boot.sh? Any chance it's going to be useful for other tests?
mvo5
added some commits
Oct 20, 2017
Some checks were not successful
Some checks were not successful
| + snap install pc-kernel --${KERNEL_CHANNEL} | ||
| + REBOOT | ||
| + elif [ "$SPREAD_REBOOT" = 1 ]; then | ||
| + # from our good starting place we refresh |
| + | ||
| + if diff -u prevKernelSignature nextKernelSignature; then | ||
| + echo "kernel in edge / stable are the same" | ||
| + exit 1 |
zyga
Oct 30, 2017
•
Edited 1 time
-
zyga
Oct 30, 2017
Contributor
-
Oct 30, 2017
Should this be an exit 1? Can we somehow skip the test. I worry that this will cause failures in the field at the wost possible moment sometime in the future, when we want to release.
Some checks were not successful
|
yep, test seems to be failing |
mvo5
added some commits
Nov 17, 2017
mvo5 commentedOct 20, 2017
This test ensures that we can go from stable->edge for pc-kernel
on core devices. It also tests revert.
This will also need to go into spread-cron and we need to set it to manual. The manual: true setting is commented out so that the test runs here once in travis before it is moved to spread-cron.