Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
tests: new test to check interfaces after reboot the system #4078
Conversation
sergiocazzolato
added some commits
Oct 25, 2017
codecov-io
commented
Oct 25, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #4078 +/- ##
==========================================
+ Coverage 76.19% 77.92% +1.73%
==========================================
Files 445 446 +1
Lines 38773 30820 -7953
==========================================
- Hits 29542 24016 -5526
+ Misses 7217 4793 -2424
+ Partials 2014 2011 -3
Continue to review full report at Codecov.
|
zyga
requested changes
Nov 8, 2017
Please check $SPREAD_REBOOT and don't do reboot forever.
mvo5
and others
added some commits
Nov 9, 2017
|
@zyga change applied, thanks for reviewing |
|
@mvo5 @zyga @stolowski, I see the test is failing and aparently it is because of the bug.
|
|
Hmm, so indeed the test shows that after reboot we have no interfaces at all:
|
| + This test checks if the interfaces are listed after the machine | ||
| + is rebooted. The test is also checking the interfaces after a | ||
| + snap is installed and removed. | ||
| + |
| +execute: | | ||
| + # install test-snapd-tools and reboot | ||
| + if [ "$SPREAD_REBOOT" = 0 ]; then | ||
| + snap install test-snapd-tools |
zyga
Nov 22, 2017
Contributor
Can you please move CONNECTED_PATTERN=":core-support +core:core-support-plug" above and then add the same test after the snap is installed but before we reboot? snap interfaces | MATCH "$CONNECTED_PATTERN"
sergiocazzolato
added some commits
Nov 22, 2017
|
@zyga, I see this when I debug it, does it help?
|
sergiocazzolato commentedOct 25, 2017
This is created to cover this bug https://bugs.launchpad.net/snapd/+bug/1721518