Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debian: make packaging/ubuntu-14.04/copyright a real file again #4095

Merged
merged 1 commit into from Oct 30, 2017
Merged

debian: make packaging/ubuntu-14.04/copyright a real file again #4095

merged 1 commit into from Oct 30, 2017

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Oct 27, 2017

The ubuntu archive rejects uploads where the debian/copyright
file is a symlink.

@mvo5
debian: make packaging/ubuntu-14.04/copyright a real file again
519b449 
The ubuntu archive rejects uploads where the debian/copyright
file is a symlink.
@mvo5 mvo5 added the ⚠ Critical High-priority stuff (e.g. to fix master) label Oct 27, 2017
@mvo5 mvo5 added this to the 2.29 milestone Oct 27, 2017
Conan-Kudo
Conan-Kudo approved these changes Oct 27, 2017
View reviewed changes
Copy link
Contributor

@Conan-Kudo Conan-Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in itself is okay, but someone needs to actually make a valid copyright file for the vendored source tree. Unless you unbundle, this file is a lie.

@codecov-io
Copy link

Codecov Report

Merging #4095 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4095   +/-   ##
=======================================
  Coverage   75.75%   75.75%           
=======================================
  Files         435      435           
  Lines       37442    37442           
=======================================
  Hits        28366    28366           
  Misses       7094     7094           
  Partials     1982     1982

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0190c29...519b449. Read the comment docs.

zyga
zyga approved these changes Oct 30, 2017
View reviewed changes
Copy link
Collaborator

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zyga zyga merged commit 3ed8605 into snapcore:master Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conan-Kudo Conan-Kudo Conan-Kudo approved these changes

@zyga zyga zyga approved these changes

Assignees
No one assigned
Labels
⚠ Critical High-priority stuff (e.g. to fix master)
Projects
None yet
Milestone
2.29
4 participants
@mvo5 @codecov-io @Conan-Kudo @zyga