interfaces/many: miscellaneous updates based on feedback from the field (2.29) #4101

Merged
merged 11 commits into from Oct 30, 2017

Conversation

Projects
None yet
4 participants
Contributor

zyga commented Oct 30, 2017

This is a backport of #4097 for 2.29:

interfaces/desktop,unity7: allow read on system and session xdg user-dirs files
interfaces/browser-support: allow /run/udev access for cuse and vhost-vsock
interfaces: allow directory read on /home/ and / by default
interfaces/removable-media: allowing read on /run/ and /run/media/
interfaces/browser-support: also allowing reading /etc/chromium/{,**}
interfaces/browser-support: allow /proc/pid/mount{s,info} to avoid confusion
interfaces/home: allow reading files and dirs that start with 'snap[^/]'
interfaces/bluez: don't mediate 'path' to/from unconfined

jdstrand added some commits Oct 27, 2017

interfaces/browser-support: allow /proc/pid/mount{s,info} to avoid co…
…nfusion

This is an information leak but disallowing it leads to developer confusion
when using the chromium content api file chooser due to a (harmless) glib
warning and the noisy AppArmor denial. This transitional interface already
allows worse accessing than this information leak, so try to be pragmatic.
interfaces/home: allow reading files and dirs that start with 'snap[^/]'
Previously we unintentionally blocked access to ~/snap-something. Add a rule
that allows these reads but still blocks ~/snap
interfaces/bluez: don't mediate 'path' to/from unconfined
For the org.bluez DBus interface we cannot specify an Object Path since
according to the bluez specification these can be anything
(https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/doc).

@zyga zyga changed the title from Policy updates xxxi for 2.29 to interfaces/many: miscellaneous updates based on feedback from the field (2.29) Oct 30, 2017

@zyga zyga added this to the 2.29 milestone Oct 30, 2017

codecov-io commented Oct 30, 2017

Codecov Report

Merging #4101 into release/2.29 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           release/2.29    #4101   +/-   ##
=============================================
  Coverage         75.78%   75.78%           
=============================================
  Files               433      433           
  Lines             37229    37229           
=============================================
  Hits              28215    28215           
  Misses             7042     7042           
  Partials           1972     1972
Impacted Files Coverage Δ
interfaces/builtin/removable_media.go 100% <ø> (ø) ⬆️
interfaces/builtin/browser_support.go 76.31% <ø> (ø) ⬆️
interfaces/builtin/hardware_observe.go 100% <ø> (ø) ⬆️
interfaces/builtin/home.go 100% <ø> (ø) ⬆️
interfaces/builtin/unity7.go 67.85% <ø> (ø) ⬆️
interfaces/builtin/bluez.go 100% <ø> (ø) ⬆️
interfaces/builtin/desktop.go 86.84% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f9f0c6...e0a8cf7. Read the comment docs.

@zyga zyga requested a review from mvo5 Oct 30, 2017

@mvo5 mvo5 merged commit 82782b2 into snapcore:release/2.29 Oct 30, 2017

7 checks passed

artful-amd64 autopkgtest finished (success)
Details
artful-i386 autopkgtest finished (success)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-amd64 autopkgtest finished (success)
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
zesty-amd64 autopkgtest finished (success)
Details

@zyga zyga deleted the zyga:policy-updates-xxxi-for-2.29 branch Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment