tests/test-snapd-service: fix shellcheck issues #4119

Merged
merged 1 commit into from Nov 3, 2017

Conversation

Projects
None yet
4 participants
Contributor

bboozzoo commented Nov 2, 2017

Fix issues raised by shellcheck 0.4.6:

In tests/lib/snaps/test-snapd-service/bin/start line 2:
snapctl get service-option > $SNAP_DATA/service-option
^-- SC2086: Double quote to prevent globbing and word splitting.

In tests/lib/snaps/test-snapd-service/bin/start-other line 2:
snapctl get service-option > $SNAP_DATA/service-option
^-- SC2086: Double quote to prevent globbing and word splitting.

In tests/lib/snaps/test-snapd-service/meta/hooks/configure line 3:
snapctl set service-option=$(snapctl get service-option-source)
^-- SC2046: Quote this to prevent word splitting.

Signed-off-by: Maciej Borzecki maciej.zenon.borzecki@canonical.com

zyga approved these changes Nov 2, 2017

Looks good, LGTM

mvo5 approved these changes Nov 2, 2017

tests/test-snapd-service: fix shellcheck issues
Fix issues raised by shellcheck 0.4.6:

  In tests/lib/snaps/test-snapd-service/bin/start line 2:
  snapctl get service-option > $SNAP_DATA/service-option
                               ^-- SC2086: Double quote to prevent globbing and word splitting.

  In tests/lib/snaps/test-snapd-service/bin/start-other line 2:
  snapctl get service-option > $SNAP_DATA/service-option
                               ^-- SC2086: Double quote to prevent globbing and word splitting.

  In tests/lib/snaps/test-snapd-service/meta/hooks/configure line 3:
  snapctl set service-option=$(snapctl get service-option-source)
                             ^-- SC2046: Quote this to prevent word splitting.

Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>

codecov-io commented Nov 3, 2017

Codecov Report

Merging #4119 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4119   +/-   ##
=======================================
  Coverage   75.61%   75.61%           
=======================================
  Files         435      435           
  Lines       37596    37596           
=======================================
  Hits        28430    28430           
  Misses       7175     7175           
  Partials     1991     1991

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6d0682...405786b. Read the comment docs.

@zyga zyga merged commit eb1d2d2 into snapcore:master Nov 3, 2017

1 of 7 checks passed

xenial-ppc64el autopkgtest finished (failure)
Details
artful-amd64 autopkgtest running
Details
artful-i386 autopkgtest running
Details
xenial-amd64 autopkgtest running
Details
xenial-i386 autopkgtest running
Details
zesty-amd64 autopkgtest running
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment