Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
interfaces: fix incorrect signature of ofono DBusPermanentSlot (2.29) #4123
Conversation
zyga
added some commits
Nov 2, 2017
zyga
changed the title from
interfaces: fix incorrect signature of ofono DBusPermanentSlot
to
interfaces: fix incorrect signature of ofono DBusPermanentSlot (2.29)
Nov 2, 2017
zyga
added this to the 2.29 milestone
Nov 2, 2017
zyga
added
the
Critical
label
Nov 2, 2017
jdstrand
approved these changes
Nov 2, 2017
Thanks for fixing this. I'll let others comment on the test changes but cursory look, +1.
|
The history here is wrong. I'll correct that. EDIT: done now. |
codecov-io
commented
Nov 2, 2017
•
Codecov Report
@@ Coverage Diff @@
## release/2.29 #4123 +/- ##
============================================
Coverage 75.8% 75.8%
============================================
Files 433 433
Lines 37250 37250
============================================
Hits 28236 28236
Misses 7042 7042
Partials 1972 1972
Continue to review full report at Codecov.
|
mvo5
merged commit 79dc972
into
snapcore:release/2.29
Nov 3, 2017
2 of 7 checks passed
artful-amd64
autopkgtest running
Details
artful-i386
autopkgtest running
Details
continuous-integration/travis-ci/pr
The Travis CI build is in progress
Details
xenial-amd64
autopkgtest running
Details
zesty-amd64
autopkgtest running
Details
xenial-i386
autopkgtest finished (success)
Details
xenial-ppc64el
autopkgtest finished (success)
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
zyga commentedNov 2, 2017
This branch addresses recently introduced bug in the ofono interface.
The interface had a buggy specification method signature that would be silently unnoticed
and would result in incorrect confinement at runtime.