interfaces: fix incorrect signature of ofono DBusPermanentSlot (2.29) #4123

Merged
merged 2 commits into from Nov 3, 2017

Conversation

Projects
None yet
5 participants
Contributor

zyga commented Nov 2, 2017

This branch addresses recently introduced bug in the ofono interface.
The interface had a buggy specification method signature that would be silently unnoticed
and would result in incorrect confinement at runtime.

zyga added some commits Nov 2, 2017

interfaces/builtin: detect unexpected specifier signatures
This patch adds a reflection-based test that checks signature of each
specification method to be what we expect. This can catch stray
silliness like the recently found ofono bug.

Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
interfaces: correct the signature of ofono DBusPermanentSlot
The invalid signature meant that the function was silently ignored and
did nothing at all.

Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>

@zyga zyga changed the title from interfaces: fix incorrect signature of ofono DBusPermanentSlot to interfaces: fix incorrect signature of ofono DBusPermanentSlot (2.29) Nov 2, 2017

@zyga zyga added this to the 2.29 milestone Nov 2, 2017

@zyga zyga added the Critical label Nov 2, 2017

Thanks for fixing this. I'll let others comment on the test changes but cursory look, +1.

+1

Contributor

zyga commented Nov 2, 2017

The history here is wrong. I'll correct that. EDIT: done now.

codecov-io commented Nov 2, 2017

Codecov Report

Merging #4123 into release/2.29 will not change coverage.
The diff coverage is 77.3%.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/2.29   #4123   +/-   ##
============================================
  Coverage          75.8%   75.8%           
============================================
  Files               433     433           
  Lines             37250   37250           
============================================
  Hits              28236   28236           
  Misses             7042    7042           
  Partials           1972    1972
Impacted Files Coverage Δ
overlord/configstate/config/transaction.go 84.45% <ø> (ø) ⬆️
overlord/snapstate/flags.go 100% <ø> (ø) ⬆️
interfaces/ifacetest/backend.go 0% <0%> (ø) ⬆️
interfaces/builtin/ofono.go 73.91% <0%> (ø) ⬆️
cmd/snap/main.go 63.58% <0%> (ø) ⬆️
cmd/snapctl/main.go 36.36% <0%> (ø) ⬆️
spdx/parser.go 84.26% <0%> (ø) ⬆️
interfaces/ifacetest/backendtest.go 0% <0%> (ø) ⬆️
cmd/snap-update-ns/main.go 0% <0%> (ø) ⬆️
overlord/configstate/configmgr.go 0% <0%> (ø) ⬆️
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e2c97c...6c9e842. Read the comment docs.

@mvo5 mvo5 merged commit 79dc972 into snapcore:release/2.29 Nov 3, 2017

2 of 7 checks passed

artful-amd64 autopkgtest running
Details
artful-i386 autopkgtest running
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
xenial-amd64 autopkgtest running
Details
zesty-amd64 autopkgtest running
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment