/snapd

interfaces: fix incorrect signature of ofono DBusPermanentSlot (2.29) #4123

Merged
merged 2 commits into from Nov 3, 2017
Commits on Nov 2, 2017
  1. @zyga

    interfaces/builtin: detect unexpected specifier signatures

    zyga committed Nov 2, 2017

    Some checks were not successful

    1 errored, 1 failing, and 5 successful checks
    continuous-integration/travis-ci/pr — The Travis CI build could not complete due to an error
    Details
    @mvo5
    xenial-amd64 — autopkgtest finished (failure)
    Details
    @mvo5
    artful-amd64 — autopkgtest finished (success)
    Details
    @mvo5
    artful-i386 — autopkgtest finished (success)
    Details
    @mvo5
    xenial-i386 — autopkgtest finished (success)
    Details
    @mvo5
    xenial-ppc64el — autopkgtest finished (success)
    Details
    @mvo5
    zesty-amd64 — autopkgtest finished (success)
    Details 
    This patch adds a reflection-based test that checks signature of each
specification method to be what we expect. This can catch stray
silliness like the recently found ofono bug.

Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
    6c9e842
  2. @zyga

    interfaces: correct the signature of ofono DBusPermanentSlot

    zyga committed Nov 2, 2017 
    The invalid signature meant that the function was silently ignored and
did nothing at all.

Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
    68f7380