snap-update-ns: add missing unit test for desired/current profile handling #4141

Merged
merged 1 commit into from Nov 7, 2017

Conversation

Projects
None yet
4 participants
Collaborator

mvo5 commented Nov 3, 2017

The cmd/snap-update-ns/main.go is a bit under-tested. This PR adds a direct unit test for the mount profile handling. It is a single test for now that tests the fix for #4139, however it should be easy to expand to test more conditions.

zyga approved these changes Nov 3, 2017

Looks nice, thank you mvo

Contributor

zyga commented Nov 3, 2017

I merged master, this should be mergable now

codecov-io commented Nov 7, 2017

Codecov Report

Merging #4141 into master will increase coverage by 0.11%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4141      +/-   ##
=========================================
+ Coverage   75.38%   75.5%   +0.11%     
=========================================
  Files         435     435              
  Lines       37724   37731       +7     
=========================================
+ Hits        28439   28489      +50     
+ Misses       7296    7248      -48     
- Partials     1989    1994       +5
Impacted Files Coverage Δ
cmd/snap-update-ns/main.go 38.46% <40%> (+38.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4839a7d...c1a418f. Read the comment docs.

@mvo5 mvo5 merged commit ec778ba into snapcore:master Nov 7, 2017

3 of 7 checks passed

artful-amd64 autopkgtest running
Details
artful-i386 autopkgtest running
Details
xenial-amd64 autopkgtest running
Details
zesty-amd64 autopkgtest running
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
xenial-i386 autopkgtest finished (success)
Details
xenial-ppc64el autopkgtest finished (success)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment