Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
snap-update-ns: add missing unit test for desired/current profile handling #4141
Conversation
|
I merged master, this should be mergable now |
codecov-io
commented
Nov 7, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #4141 +/- ##
=========================================
+ Coverage 75.38% 75.5% +0.11%
=========================================
Files 435 435
Lines 37724 37731 +7
=========================================
+ Hits 28439 28489 +50
+ Misses 7296 7248 -48
- Partials 1989 1994 +5
Continue to review full report at Codecov.
|
mvo5
merged commit ec778ba
into
snapcore:master
Nov 7, 2017
3 of 7 checks passed
artful-amd64
autopkgtest running
Details
artful-i386
autopkgtest running
Details
xenial-amd64
autopkgtest running
Details
zesty-amd64
autopkgtest running
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
xenial-i386
autopkgtest finished (success)
Details
xenial-ppc64el
autopkgtest finished (success)
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mvo5 commentedNov 3, 2017
The cmd/snap-update-ns/main.go is a bit under-tested. This PR adds a direct unit test for the mount profile handling. It is a single test for now that tests the fix for #4139, however it should be easy to expand to test more conditions.