Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
snappy: add default security profile if none is specified #416
Conversation
mvo5
added some commits
Feb 2, 2016
|
Looks good, +1 |
mvo5
closed this
Feb 2, 2016
mvo5
reopened this
Feb 2, 2016
niemeyer
reviewed
Feb 2, 2016
| @@ -71,6 +71,12 @@ var ( | ||
| SecurityCaps: []string{}, | ||
| } | ||
| + // the default migration skill if no default is uses in |
niemeyer
Feb 2, 2016
Contributor
That doesn't sound right. We don't want the migration-skill to come in by default. We want people to explicitly mention it if they depend on anything non-default.
The permissions we discussed so far are:
- Writing into the applications own space. That should definitely come by default. It did so in the old convention, and it should continue to do so in the new convention.
- Network client access. That used to be a default in the old convention when nothing was specified, and we agreed to not have it by default in the new convention, at least for now. If people want network access, they need to explicitly mention migration-skill. That ensures we can go into either direction soon depending on what we decide at the sprint, without having to break anyone.
Is there anything else we're missing that exists in the default template of the old convention?
mvo5
added some commits
Feb 2, 2016
|
@niemeyer Thanks for the review! I changed this now to the following:
I hope this addresses the concerns. Please let me know if there is anything I can do. |
mvo5
changed the title from
Bugfix/add migration skill
to
snappy: add default security profile if none is specified
Feb 2, 2016
niemeyer
reviewed
Feb 2, 2016
| @@ -762,7 +768,12 @@ func generatePolicy(m *snapYaml, baseDir string) error { | ||
| if err != nil { | ||
| return err | ||
| } | ||
| + | ||
| + // if no skill is specified, use the defaultSecurityPolicy |
niemeyer
Feb 2, 2016
Contributor
// TODO This is not actually right. Even if there are skills, we still want to give the snap
// a default set of allowances, such as being able to read and write in its own directories
// and perhaps network access (we're still deciding on that one). So the real logic we
// want here is: give the snap a default set of permissions, and then whatever else the
// skills permit (migration or not). This is coming soon.
|
LGTM, let's please just have the comment indicated replaced by that text so it's more clear where we are going. |
|
Thanks a bunch! Comment added. |
|
retest this please |
|
retest this please |
mvo5 commentedFeb 2, 2016
Instead of forcing people to explicitly add the migration-skill do so implicitly if no other skill is specified.