Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon: for /v2/logs, 404 when no services are found #4194

Merged
merged 2 commits into from Nov 9, 2017

Conversation

chipaca
Copy link
Contributor

@chipaca chipaca commented Nov 9, 2017

When getting service logs, if a snap name is given but it has no
services, a 404 is returned. However if no names were given we would
call journalctl with no match arguments (because ∀ is true on the
empty set), meaning we'd ship all the logs out. This fixes that.

When getting service logs, if a snap name is given but it has no
services, a 404 is returned. However if no names were given we would
call journalctl with no match arguments (because ∀ is true on the
empty set), meaning we'd ship all the logs out. This fixes that.
@mvo5 mvo5 added this to the 2.29 milestone Nov 9, 2017
Copy link
Contributor

@stolowski stolowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. +1

@codecov-io
Copy link

codecov-io commented Nov 9, 2017

Codecov Report

Merging #4194 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4194      +/-   ##
=========================================
- Coverage   75.56%   75.5%   -0.06%     
=========================================
  Files         436     434       -2     
  Lines       37814   37821       +7     
=========================================
- Hits        28573   28556      -17     
- Misses       7246    7267      +21     
- Partials     1995    1998       +3
Impacted Files Coverage Δ
daemon/api.go 72.21% <100%> (+0.04%) ⬆️
httputil/useragent.go 77.5% <0%> (-7.5%) ⬇️
cmd/snap-seccomp/main.go 46.98% <0%> (-7.23%) ⬇️
interfaces/sorting.go 92.3% <0%> (-1.1%) ⬇️
overlord/ifacestate/helpers.go 59.6% <0%> (-0.67%) ⬇️
httputil/redirect18.go
httputil/transport17.go
cmd/snap-update-ns/entry.go 93.75% <0%> (+0.27%) ⬆️
interfaces/mount/entry.go 67.4% <0%> (+3.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15565f3...edb2d25. Read the comment docs.

@chipaca chipaca removed this from the 2.29 milestone Nov 9, 2017
@mvo5 mvo5 merged commit 6219ca2 into snapcore:master Nov 9, 2017
@chipaca chipaca deleted the no-services-no-logs branch November 14, 2017 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants