interfaces/many: misc updates for default, browser-support, opengl, desktop, unity7, x11 #4359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 5, 2017 16:40
…actl Since snapd still uses SECCOMP_RET_KILL, we have added a seccomp workaround rule to allow mknod on character devices because chromium unconditionally performs a mknod() to create the /dev/nvidiactl device, regardless of if it exists or not or if the process has CAP_MKNOD or not. Since we don't want to actually grant the ability to create character devices, explicitly deny the capability. When snapd uses SECCOMP_RET_ERRNO, we can remove these rules. References: https://forum.snapcraft.io/t/call-for-testing-chromium-62-0-3202-62/2569/46
|
ubuntu-14.04 prepare failed with: I've restarted the build. |
bboozzoo
approved these changes
Dec 6, 2017
Codecov Report
@@ Coverage Diff @@
## master #4359 +/- ##
==========================================
+ Coverage 77.91% 77.96% +0.05%
==========================================
Files 446 446
Lines 30820 30816 -4
==========================================
+ Hits 24014 24027 +13
+ Misses 4797 4780 -17
Partials 2009 2009
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note the opengl changes look larger than they are: the first commit just removes leading whitespace and was confirmed to do nothing else with
git diff -w. The individual commit at 6b8f3ee shows that better, with 4b996f4 showing the real change.