/snapd

Support HOME for systemd units #442

Merged
merged 2 commits into from Feb 5, 2016
+4 −3

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@sergiusens @chipaca @zyga @kyrofa
@sergiusens
Contributor

sergiusens commented Feb 5, 2016

%h does not work with systemd as it is PID1. From the manpage:

Please note that specifiers "%U", "%h", "%s" are mostly useless when
systemd is running in system mode.

LP: #1466234
@sergiusens
Support HOME for systemd units 
%h does not work with systemd as it is PID1. From the manpage:

> Please note that specifiers "%U", "%h", "%s" are mostly useless when
> systemd is running in system mode.

LP: #1466234

Some checks were not successful

1 failing and 1 successful checks
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
@snappy-m-o
Integration tests — Success 60 tests run, 0 skipped, 0 failed.
Details
cce7938
@chipaca
Member

chipaca commented Feb 5, 2016

👍
@zyga
Contributor

zyga commented Feb 5, 2016

+1
@zyga
Contributor

zyga commented Feb 5, 2016

@sergiusens can you please have a look at the broken unit tests. It seems to require some attention.
@sergiusens
Contributor

sergiusens commented Feb 5, 2016

@zyga yeah, on it
@sergiusens
Contributor

sergiusens commented Feb 5, 2016

As in, running locally now ;-)
@sergiusens
Fix the click unit's unit test 
Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>

All checks have passed

3 successful checks
@snappy-m-o
Integration tests — Success 60 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage decreased (-0.2%) to 70.156%
Details
faa32ae
@sergiusens
Contributor

sergiusens commented Feb 5, 2016 

         ▌     ▐            ▜   ▌             ▗ ▌  ▜
     ▌  ▌▛▀▖▝▀▖▜▀  ▞▀▖▞▀▖▌ ▌▐ ▞▀▌ ▛▀▖▞▀▖▞▀▘▞▀▘▄ ▛▀▖▐ ▌ ▌ ▞▀▌▞▀▖ ▌  ▌▙▀▖▞▀▖▛▀▖▞▀▌
     ▐▐▐ ▌ ▌▞▀▌▐ ▖ ▌ ▖▌ ▌▌ ▌▐ ▌ ▌ ▙▄▘▌ ▌▝▀▖▝▀▖▐ ▌ ▌▐ ▚▄▌ ▚▄▌▌ ▌ ▐▐▐ ▌  ▌ ▌▌ ▌▚▄▌
      ▘▘ ▘ ▘▝▀▘ ▀  ▝▀ ▝▀ ▝▀▘ ▘▝▀▘ ▌  ▝▀ ▀▀ ▀▀ ▀▘▀▀  ▘▗▄▘ ▗▄▘▝▀   ▘▘ ▘  ▝▀ ▘ ▘▗▄▘

zyga added a commit that referenced this pull request Feb 5, 2016

@zyga
Merge pull request #442 from sergiusens/support-home-in-systemd-units 
Support HOME for systemd units
06582d6

@zyga zyga merged commit 06582d6 into snapcore:master Feb 5, 2016
3 checks passed

3 checks passed

Integration tests Success 60 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.2%) to 70.156%
Details
@kyrofa
Member

kyrofa commented Feb 5, 2016

Isn't this actually LP: #1541898? LP: #1466234 involves apps run as sudo. Appreciated either way 😃 .
@sergiusens
Contributor

sergiusens commented Feb 5, 2016

@kyrofa there were many many bugs opened, this one matched somewhat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment