/snapd

skills,skills/types: pass slot to SlotSecuritySnippet() #490

Merged
merged 3 commits into from Feb 23, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@zyga @mvo5 @niemeyer
@zyga
Contributor

zyga commented Feb 16, 2016

This branch is applied on top of #489 for build correctness.

It turns out that we need to pass slot instance to a
Type.SlotSecuritySnippet because UDevSecurity system need to put the
name of the consuming snap (which is only known through the skill slot)
into the generated snippet.

Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com

zyga added some commits Feb 16, 2016

@zyga
skills/types: teach bool-file about udev security 
Since bool-file doesn't need any additional rules all the change does is
recognizes udev and returns nil snippets. Tests are extended to check
for this condition.

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>

Some checks were not successful

1 failing and 2 successful checks
@snappy-m-o
Integration tests — 19 tests run, 0 skipped, 7 failed.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage decreased (-0.0%) to 70.13%
Details
3dc457d
@zyga
skills,skills/types: pass slot to SlotSecuritySnippet() 
It turns out that we need to pass slot instance to a
Type.SlotSecuritySnippet because UDevSecurity system need to put the
name of the consuming snap (which is only known through the skill slot)
into the generated snippet.

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>

Some checks were not successful

1 failing and 2 successful checks
@snappy-m-o
Integration tests — 19 tests run, 0 skipped, 7 failed.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage decreased (-0.0%) to 70.13%
Details
e662494
@mvo5
Collaborator

mvo5 commented Feb 22, 2016

LGTM
@zyga
Merge branch 'master' of github.com:ubuntu-core/snappy into skills-sl… 
…ot-security

All checks have passed

3 successful checks
@snappy-m-o
Integration tests — Success 64 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — First build on master at 70.276%
Details
dd985cc
@zyga
Contributor

zyga commented Feb 23, 2016

Merged with master to re-test with integration test fixes
@niemeyer
Contributor

niemeyer commented Feb 23, 2016

LGTM

niemeyer added a commit that referenced this pull request Feb 23, 2016

@niemeyer
Merge pull request #490 from zyga/skills-slot-security 
skills,skills/types: pass slot to SlotSecuritySnippet()
5bcb202

@niemeyer niemeyer merged commit 5bcb202 into snapcore:master Feb 23, 2016
3 checks passed

3 checks passed

Integration tests Success 64 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 70.276%
Details

@zyga zyga deleted the zyga:skills-slot-security branch Mar 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment