New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interfaces/many: miscellaneous updates for default, desktop, desktop-legacy, system-observe, hardware-observe, opengl and gpg-keys #5189

Merged
merged 9 commits into from May 23, 2018

Conversation

Projects
None yet
4 participants
@jdstrand
Copy link
Contributor

jdstrand commented May 22, 2018

  • interfaces/system-observe: allow using org.freedesktop.DBus.Peer.GetMachineId
  • interfaces: allow use of dbus-send executable by default
  • interfaces/hardware-observe: allow lsmem and sysfs memory status and ranges
  • interfaces/opengl: misc accesses for CUDA
  • interfaces/gpg-keys: update comments regarding random seed file
  • interfaces/system-observe: allow reading /proc/pid/fdinfo/* for lsof
  • interfaces/desktop-legacy: read snapd desktop dir and this snap's desktop file
  • interfaces/desktop: allow calling org.gtk.gio.DesktopAppInfo.Launched
  • interfaces/default: allow reading own fds via /proc (and /dev/std{in,out,err})

jdstrand added some commits May 22, 2018

interfaces: allow use of dbus-send executable by default
Only the desktop and unity7 interfaces had rules for dbus-send, but we can
allow it by default since we mediate dbus messages with AppArmor. This will
reduce friction for snaps that need dbus-send from shell scripts, etc.
interfaces/default: allow reading own fds via /proc (and /dev/std{in,…
…out,err})

Allow reading and writing to our file descriptors in /proc which, for example,
allow access to /dev/std{in,out,err} which are all symlinks to
/proc/self/fd/{0,1,2} respectively. To support the open(..., O_TMPFILE)
linkat() temporary file technique, allow all fds. Importantly, access to
another's task's fd via this proc interface is mediated via 'ptrace (read)'
(readonly) and 'ptrace (trace)' (read/write) which is denied by default, so
this rule by itself doesn't allow opening another snap's fds via proc.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 22, 2018

Codecov Report

Merging #5189 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5189   +/-   ##
=======================================
  Coverage   78.89%   78.89%           
=======================================
  Files         494      494           
  Lines       37296    37296           
=======================================
  Hits        29425    29425           
  Misses       5501     5501           
  Partials     2370     2370
Impacted Files Coverage Δ
interfaces/builtin/unity7.go 68.18% <ø> (ø) ⬆️
interfaces/builtin/opengl.go 100% <ø> (ø) ⬆️
interfaces/builtin/desktop_legacy.go 100% <ø> (ø) ⬆️
interfaces/builtin/gpg_keys.go 100% <ø> (ø) ⬆️
interfaces/builtin/hardware_observe.go 100% <ø> (ø) ⬆️
interfaces/builtin/system_observe.go 100% <ø> (ø) ⬆️
interfaces/builtin/desktop.go 92.72% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cafdda...29bb40d. Read the comment docs.

@mvo5 mvo5 added this to the 2.33 milestone May 23, 2018

@mvo5

mvo5 approved these changes May 23, 2018

@bboozzoo bboozzoo merged commit 8378e64 into snapcore:master May 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jdstrand

This comment has been minimized.

Copy link
Contributor Author

jdstrand commented May 23, 2018

Thanks for the reviews and merge! :)

@jdstrand jdstrand deleted the jdstrand:policy-updates-xxxvii branch May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment