Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
tests: fix raciness in stop mode tests #5526
This branch fixes raciness in the stop-mode tests. This test was failing for
The first issue is fixed with a "stamp" like file that we look for in the test.
The second issue is fixed by re-writing the test in Python 3. This requires
This is fixed by writing the test service in Python and not relying on
Shell is tricky, more than we though, and we keep learning this the hard way.
Signed-off-by: Zygmunt Krynicki firstname.lastname@example.org
@@ Coverage Diff @@ ## master #5526 +/- ## ========================================== + Coverage 79.06% 79.29% +0.23% ========================================== Files 514 514 Lines 38949 39492 +543 ========================================== + Hits 30795 31316 +521 - Misses 5681 5688 +7 - Partials 2473 2488 +15
referenced this pull request
Jul 18, 2018
As a general comment, the test still suffers some issues but we suspect those are in our general log extracting helpers. We've decided to merge this as is as it fixes real issues. Investigation of the log extractor bug continues in the branch referenced by mvo above.