Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian: add missing breaks on cosmic #5656

Merged
merged 1 commit into from Aug 15, 2018
Merged

Conversation

mvo5
Copy link
Collaborator

@mvo5 mvo5 commented Aug 14, 2018

On 18.04 the released version of apt (1.6.1) has a bug that causes
problem on "apt purge snapd". To ensure this won't happen we added the
right "Breaks: apt (<< 1.6.3)" to debian/control.

However on cosmic there is the same bug in apt just with a different
version number (<< 1.7.0~alpha2). It looks like the autopkgtest
chroots have an outdated apt on cosmic so we need this breaks on
cosmic as well.

@mvo5 mvo5 added this to the 2.35 milestone Aug 14, 2018
@codecov-io
Copy link

codecov-io commented Aug 14, 2018

Codecov Report

Merging #5656 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5656      +/-   ##
==========================================
+ Coverage   78.94%   78.94%   +<.01%     
==========================================
  Files         520      520              
  Lines       39668    39668              
==========================================
+ Hits        31315    31317       +2     
+ Misses       5806     5805       -1     
+ Partials     2547     2546       -1
Impacted Files Coverage Δ
overlord/hookstate/hookmgr.go 74.51% <0%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17705b4...24b2e1f. Read the comment docs.

@mvo5 mvo5 added the Simple 😃 A small PR which can be reviewed quickly label Aug 15, 2018
@mvo5 mvo5 force-pushed the break-cosmic branch 2 times, most recently from fd104a1 to a17f7a5 Compare August 15, 2018 07:40
On 18.04 the released version of apt (1.6.1) has a bug that causes
problem on "apt purge snapd". To ensure this won't happen add the
right "Breaks: apt (<< 1.6.3)" to debian/control.

However on cosmic there is the same bug in apt just with a different
version number (<< 1.7.0~alpha2). It looks like the autopkgtest
chroots have an outdated apt on cosmic so we need this breaks on
cosmic as well.
Copy link
Contributor

@chipaca chipaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bugs of the world are a constant quantity.

@pedronis pedronis changed the title debian: add missing breaks on comisc debian: add missing breaks on cosmic Aug 15, 2018
@mvo5 mvo5 merged commit 6867c62 into snapcore:master Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
3 participants