Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
client,daemon,snappy,systemd: %s/\<ServiceName\>/AppName/g #601
Conversation
mvo5
reviewed
Mar 8, 2016
| @@ -60,7 +60,7 @@ type ServiceStatus struct { | ||
| SubState string `json:"sub_state"` | ||
| UnitFileState string `json:"unit_file_state"` | ||
| SnapName string `json:"snap_name"` | ||
| - ServiceName string `json:"service_name"` | ||
| + AppName string `json:"service_name"` |
zyga
Mar 8, 2016
Contributor
As mentioned in the commit message, I'd like to do this separately to have smaller impact of each change. We will have to look at the REST API to see how many things are affected there.
|
One question, but personally I think this is not as important as the other renames because the app happens to be a service so its not that confusing (but maybe that is just me :) |
|
|
zyga
closed this
Mar 8, 2016
zyga
reopened this
Mar 8, 2016
added a commit
that referenced
this pull request
Mar 8, 2016
zyga
merged commit b32eaf9
into
snapcore:master
Mar 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
zyga commentedMar 8, 2016
This patch changes service name into application name. This was
requested by Gustavo yesterday during a code review. I chose not to
change JSON serialization settings yet to minimize the affected code (so
on-the-wire protocol remains the same).
Wire changes will probably need some more work anyway (dashes-everywhere
initiative plus plenty of legacy terms in various places).
Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com