/snapd

snappy: simplify framework application wrapper test #602

Merged
merged 2 commits into from Mar 8, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zyga @stevenwilkin
@zyga
Contributor

zyga commented Mar 8, 2016

This patch makes a simple framework binary wrapper generator test
explicit, that is not based on an earlier test for non-framework binary
wrapper. The blind text replacements done by this test were confusing
and easily broke with refactoring of the code elsewhere so before
landing the refactoring, I'd like to make this test very easy to follow.

Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com
@zyga
snappy: simplify framework application wrapper test 
This patch makes a simple framework binary wrapper generator test
explicit, that is not based on an earlier test for non-framework binary
wrapper. The blind text replacements done by this test were confusing
and easily broke with refactoring of the code elsewhere so before
landing the refactoring, I'd like to make this test very easy to follow.

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>

Some checks were not successful

1 failing and 1 successful checks
@snappy-m-o
Integration tests — 65 tests run, 0 skipped, 3 failed.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
5f1446e
@stevenwilkin
Member

stevenwilkin commented Mar 8, 2016

👍
@zyga
Merge branch 'master' into launcher-cleanup

Some checks were not successful

1 failing and 1 successful checks
@snappy-m-o
Integration tests — 65 tests run, 0 skipped, 3 failed.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
fb40859

zyga added a commit that referenced this pull request Mar 8, 2016

@zyga
Merge pull request #602 from zyga/launcher-cleanup 
snappy: simplify framework application wrapper test

All checks have passed

2 successful checks
continuous-integration/travis-ci/push — The Travis CI build passed
Details
coverage/coveralls — First build on master at 71.687%
Details
f6908e7

@zyga zyga merged commit f6908e7 into snapcore:master Mar 8, 2016
1 of 2 checks passed

1 of 2 checks passed

Integration tests Started
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment