/snapd

snappy: pass AppName to generateSnapBinaryWrapper #603

Merged
merged 2 commits into from Mar 8, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@zyga @stevenwilkin @mvo5
@zyga
Contributor

zyga commented Mar 8, 2016

This branch passes application (executable) name to the application
wrapper generator function. This will be soon required as input to the
new, simplified ubuntu-core-launcher.

Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com

zyga added some commits Mar 8, 2016

@zyga
snappy: pass AppName to generateSnapBinaryWrapper 
This patch passes application (executable) name to the application
wrapper generator function. This will be soon required as input to the
new, simplified ubuntu-core-launcher.

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
d83fdb9
@zyga
snappy: ensure that AppName makes it to generated wrapper 
This patch is a temporary test to ensure that generated wrapper scripts
have both snap and application name inside them. This keeps the previous
commit honest before the upcoming switch to the new syntax of the
ubuntu-core-launcher.

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>

Some checks were not successful

1 failing and 1 successful checks
@snappy-m-o
Integration tests — 65 tests run, 0 skipped, 3 failed.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
2d306d2
@stevenwilkin
Member

stevenwilkin commented Mar 8, 2016

👍
@mvo5
Collaborator

mvo5 commented Mar 8, 2016

👍

mvo5 added a commit that referenced this pull request Mar 8, 2016

@mvo5
Merge pull request #603 from zyga/launcher-cleanup 
 snappy: pass AppName to generateSnapBinaryWrapper

All checks have passed

2 successful checks
continuous-integration/travis-ci/push — The Travis CI build passed
Details
coverage/coveralls — First build on master at 71.7%
Details
acef35f

@mvo5 mvo5 merged commit acef35f into snapcore:master Mar 8, 2016
1 of 2 checks passed

1 of 2 checks passed

Integration tests 65 tests run, 0 skipped, 3 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment