snap,snappy,systemd: %s/\<SNAP_ORIGIN\>/SNAP_DEVELOPER/g #605

Merged
merged 2 commits into from Mar 8, 2016

Conversation

Projects
None yet
4 participants
Contributor

zyga commented Mar 8, 2016

This patch begins the change away from "origin" towards the "snap
developer". The change starts with alterations of the public-facing
environment variables.

I will follow it with internal changes to rename "origin" to "developer"
and finally to remove the special-cased frameworks which currently,
artificially, always have an empty origin field. This change will be
intertwined with changes to application launchers that will gain the new
feature of having a special-cased short wrapper name of just Snap.Name
in the only case where App.Name is the same as Snap.Name. This will
allow things like docker not to be spelled out as docker.docker but
simply docker.

Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com

snap,snappy,systemd: %s/\<SNAP_ORIGIN\>/SNAP_DEVELOPER/g
This patch begins the change away from "origin" towards the "snap
developer". The change starts with alterations of the public-facing
environment variables.

I will follow it with internal changes to rename "origin" to "developer"
and finally to remove the special-cased frameworks which currently,
artificially, always have an empty origin field. This change will be
intertwined with changes to application launchers that will gain the new
feature of having a special-cased short wrapper name of just Snap.Name
in the only case where App.Name is the same as Snap.Name. This will
allow things like docker not to be spelled out as docker.docker but
simply docker.

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Member

stevenwilkin commented Mar 8, 2016

👍

Contributor

niemeyer commented Mar 8, 2016

LGTM, but please wait for @mvo5 or @chipaca. The suggestion was mine, so we need to double check with someone with more background.

Collaborator

mvo5 commented Mar 8, 2016

This looks fine, I wonder if we could even remove it entirely though. No strong opinion either way.

mvo5 added a commit that referenced this pull request Mar 8, 2016

Merge pull request #605 from zyga/launcher-cleanup
snap,snappy,systemd: %s/\<SNAP_ORIGIN\>/SNAP_DEVELOPER/g

@mvo5 mvo5 merged commit 060599c into snapcore:master Mar 8, 2016

0 of 2 checks passed

Integration tests No test results found.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment