interfaces: add default seccomp template #611

Merged
merged 1 commit into from Mar 8, 2016

Conversation

Projects
None yet
3 participants
Contributor

zyga commented Mar 8, 2016

This patch copies the default seccomp template that applies to all applications
in all snaps. Since we're keeping all the interface implementations in go it is
easier and arguably more correct to also hold the base policy in the same
place.

Subsequent patches will use this template and incorporate interface-specific
security snippets into it.

Signed-off-by: Zygmunt Krynicki zygmunt.krynicki@canonical.com

interfaces: add default seccomp template
This patch copies the default seccomp template that applies to all applications
in all snaps. Since we're keeping all the interface implementations in go it is
easier and arguably more correct to also hold the base policy in the same
place.

Subsequent patches will use this template and incorporate interface-specific
security snippets into it.

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
Contributor

niemeyer commented Mar 8, 2016

Why are we copying this in? Isn't there a statement in the seccomp syntax to simply inherit from it?

Contributor

zyga commented Mar 8, 2016

I don't think seccomp has one. I'll check. My main motivation for having it baked-in is so that nothing form outside snappy is required to run with security (so we don't need to live in lockstep with ubuntu-core-security, we don't have to read it separately from a file, we don't have to invalidate it when it gets updated out-of-bound on the desktop, etc.).

Contributor

niemeyer commented Mar 8, 2016

Nevermind.. @jdstrand says this is probably the best way to go, so LGTM.

Please get the second review from @jdstrand himself.

Contributor

jdstrand commented Mar 8, 2016

The seccomp policy is the same as what we have in ubuntu-core-security/data/seccomp/templates/ubuntu-core/16.04/default. LGTM.

zyga added a commit that referenced this pull request Mar 8, 2016

Merge pull request #611 from zyga/seccomp
 interfaces: add default seccomp template

@zyga zyga merged commit 5db2fdc into snapcore:master Mar 8, 2016

1 check failed

Integration tests 22 tests run, 0 skipped, 7 failed.
Details

@zyga zyga deleted the zyga:seccomp branch Mar 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment