New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add core18 only hooks test and fix running core18 only on classic #6118

Merged
merged 5 commits into from Nov 9, 2018

Conversation

Projects
None yet
3 participants
@mvo5
Copy link
Collaborator

mvo5 commented Nov 8, 2018

This PR tests that we can run hooks like configure on systems that
do not have the core snap, just the core18 base. We got a report
that this breaks and this test verifies that it works correctly.

@mvo5 mvo5 force-pushed the mvo5:tests-core18-base-configure branch 2 times, most recently from 6b84b59 to 857daef Nov 8, 2018

@mvo5 mvo5 changed the title tests: add core18 only hooks test tests: add core18 only hooks test and fix running core18 only Nov 8, 2018

@mvo5 mvo5 changed the title tests: add core18 only hooks test and fix running core18 only tests: add core18 only hooks test and fix running core18 only on classic Nov 8, 2018

@mvo5 mvo5 added this to the 2.36 milestone Nov 8, 2018

@mvo5 mvo5 added the Squash-merge label Nov 8, 2018

@mvo5 mvo5 force-pushed the mvo5:tests-core18-base-configure branch 2 times, most recently from 2ad001e to 6afc07f Nov 8, 2018

mvo5 added some commits Nov 8, 2018

tests: add core18 only hooks test
This PR tests that we can run hooks like configure on systems that
do not have the core snap, just the core18 base. We got a report
that this breaks and this test verifies that it works correctly.

@mvo5 mvo5 force-pushed the mvo5:tests-core18-base-configure branch from 6afc07f to 4667e59 Nov 9, 2018

@mvo5 mvo5 removed the Squash-merge label Nov 9, 2018

rm -f /var/lib/snapd/state.json
systemctl start snapd
snap wait system seed.loaded

This comment has been minimized.

@bboozzoo

bboozzoo Nov 9, 2018

Contributor
Suggested change Beta

@mvo5 mvo5 force-pushed the mvo5:tests-core18-base-configure branch from 77723aa to fd5742d Nov 9, 2018

@zyga

zyga approved these changes Nov 9, 2018

Copy link
Contributor

zyga left a comment

LGTM

#shellcheck source=tests/lib/dirs.sh
. "$TESTSLIB/dirs.sh"
echo "Ensure all snaps are gone"
$LIBEXECDIR/snapd/snap-mgmt --purge

This comment has been minimized.

@zyga

zyga Nov 9, 2018

Contributor

I was worried this would remove snapd.service but it doesn't seem to touch files belonging to the package. As such this is ok.

@mvo5 mvo5 merged commit c4a52eb into snapcore:master Nov 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment