/snapd

snappy: use $snap.$app as per-app udev tag #612

Merged
merged 2 commits into from Mar 8, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@zyga @mvo5 @elopio
@zyga
Contributor

zyga commented Mar 8, 2016

This patch changes the so-called UdevAppName that is passed to
ubuntu-core-launcher from $snap.$origin (or just $snap for frameworks)
to $snap.$app. This change allows for per-application udev device
tagging and aligns us with upcoming changes to the ubuntu-core-launcher
that will simplify its operation.

NOTE: This just sets the base mechanism in place. We can tweak the actual value later.

zyga added some commits Mar 8, 2016

@zyga
snappy: use $snap.$app as per-app udev tag (foreground apps) 
This patch changes the so-called UdevAppName that is passed to
ubuntu-core-launcher from $snap.$origin (or just $snap for frameworks)
to $snap.$app. This change allows for per-application udev device
tagging and aligns us with upcoming changes to the ubuntu-core-launcher
that will simplify its operation.

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
28d08fb
@zyga
snappy: use $snap.$app as per-app udev tag (background apps) 
This patch changes the so-called UdevAppName that is passed to
ubuntu-core-launcher from $snap.$origin (or just $snap for frameworks)
to $snap.$app. This change allows for per-application udev device
tagging and aligns us with upcoming changes to the ubuntu-core-launcher
that will simplify its operation.

Signed-off-by: Zygmunt Krynicki <zygmunt.krynicki@canonical.com>
547f51d
snappy/binaries.go
@@ -112,7 +111,7 @@ ubuntu-core-launcher {{.UdevAppName}} {{.AaProfile}} {{.Target}} "$@"
SnapArch: arch.UbuntuArchitecture(),
SnapPath: pkgPath,
Version: m.Version,
- UdevAppName: udevPartName,
+ UdevAppName: fmt.Sprintf("%s.%s", m.Name, app.Name),
@mvo5

mvo5 Mar 8, 2016

Collaborator

I wonder if we should use "_" here for the decliner? This would allow us to still have the full snapname.origin_appname ID style string.

@mvo5
Collaborator

mvo5 commented Mar 8, 2016

Hm, nevermind.

mvo5 added a commit that referenced this pull request Mar 8, 2016

@mvo5
Merge pull request #612 from zyga/launcher-cleanup 
snappy: use $snap.$app as per-app udev tag

All checks have passed

2 successful checks
continuous-integration/travis-ci/push — The Travis CI build passed
Details
coverage/coveralls — First build on master at 71.691%
Details
54fb30f

@mvo5 mvo5 merged commit 54fb30f into snapcore:master Mar 8, 2016
1 check failed

1 check failed

Integration tests 22 tests run, 0 skipped, 7 failed.
Details
@elopio
Member

elopio commented Mar 9, 2016

@zyga this branch introduced 7 failures in the integration suite. The failures are like this:

sudo snappy install hello-world/edge --allow-unauthenticated
Installing hello-world/edge
Name Date Version Developer
canonical-pc 2016-02-02 3.0 canonical
canonical-pc-linux 2016-03-07 4.4.0-10-1 canonical
hello-world 2016-03-03 5.0 canonical
ubuntu-core 2016-03-08 16.04.0-24 canonical
hello-world.echo
binary must be inside /snaps/hello-world.echo/

I reported the bug at https://bugs.launchpad.net/snappy/+bug/1554804
@zyga
Contributor

zyga commented Mar 9, 2016

@elopio Thanks, we're looking into this now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment