snappy: support generation of short binary names #688

mvo5 · Mar 18, 2016

This branch modifies generateBinaryName to generate a short name if the appname and the snapname match. This prepares the removal of frameworks.

niemeyer · Mar 18, 2016

Slightly surprising to see filepath.Base here. We should never have a path in the app name.

We need to validate those elsewhere if we're not yet doing that.

We have that for hooks AFAIR (the only case today)

I have a similar function in interfaces WrapperNameForApp. We should de-dupe at some point.

niemeyer · Mar 18, 2016

LGTM!

zyga · Mar 18, 2016

+1

stevenwilkin · Mar 21, 2016

          	"github.com/ubuntu-core/snappy/snap/snapenv"
          )
          // generate the name
          func generateBinaryName(m *snapYaml, app *AppYaml) string {
          	var binName string
-        -	if m.Type == snap.TypeFramework {
+        +	if app.Name == m.Name {
          		binName = filepath.Base(app.Name)

snapcore/snapd