/snapd

make run-hooks run before firstboot #71

Merged
merged 1 commit into from Nov 10, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@chipaca @mvo5 @niemeyer
@chipaca
Member

chipaca commented Nov 10, 2015

If the oem package has configuration for preinstalled packages, firstboot will attempt to apply that configuration. Run-hooks creates the apparmor profiles under which those configuration hooks need to run, so it needs to run before them.

This fixes lp:1511435.
@chipaca
make run-hooks run before firstboot

All checks have passed

2 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
coverage/coveralls — Coverage increased (+0.02%) to 65.65%
Details
a3c3bb6
@mvo5
Collaborator

mvo5 commented Nov 10, 2015

Thanks, nice catch. +1
@niemeyer
Contributor

niemeyer commented Nov 10, 2015

Thanks!

niemeyer added a commit that referenced this pull request Nov 10, 2015

@niemeyer
Merge pull request #71 from chipaca/fix-run-hooks-order 
make run-hooks run before firstboot
bd25292

@niemeyer niemeyer merged commit bd25292 into snapcore:master Nov 10, 2015
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 65.65%
Details

@chipaca chipaca deleted the chipaca:fix-run-hooks-order branch Dec 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment