Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
interfaces: add log-observe from ubuntu-core-security #723
Conversation
jdstrand
added some commits
Mar 23, 2016
jdstrand
changed the title from
Log observe
to
interfaces: add log-observe from ubuntu-core-security
Mar 23, 2016
|
add to whitelist |
|
This looks fine. Fwiw I used https://github.com/ubuntu-core/snappy/compare/master...jdstrand:log-observe?expand=1 to compare, for some reason the github diff included changes that are already in master. However I doubt the value of the tests, it seems they are mostly testing what is already tested from commonInterface, i.e. the NewLogObserverInterface in itself has only the apparmor snippet and the name that is unique and different from commonInterface. |
|
LGTM FYI: for tests I'd keep them as is. It will be easier to add interface-specific tests (e.g. regression checks or anything similar) this way. We could spend some time de-duplicating them after 16.04. |
|
I'm merging all security interface branches, and adding a single card in Trello to track the points raised which were not addressed. |
jdstrand commentedMar 23, 2016
interfaces: add log-observe from ubuntu-core-security