Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: use track/risk for "channel" name when parsing store details #7255

Merged

Conversation

@stolowski
Copy link
Contributor

commented Aug 14, 2019

Followup to #7199. With this change the output of v2/find?.. call to snapd API returns channel infos as follows:

"latest/stable" : {
  "channel" : "latest/stable",
  "version" : "3.16",
  ...
}

instead of:

"latest/stable" : {
  "channel" : "stable",
  "version" : "3.16",
 ...
}

This is required because store API omits "latest/" in channel names.

This change is for ubuntu software center; it is not yet reflected in the snap info .. output because it has special-casing for "latest/" and just drops it, leaving the risk level only.

Use track/risk for "channel" name when parsing store details as store…
… doesn't return "latest/" for channel names.

With this change the output of v2/find call to snapd API returns channel chunk as follows:

"latest/stable" : {
  "channel" : "latest/stable",
  "version" : "3.16",
  ...
}

instead of:

"latest/stable" : {
  "channel" : "stable",
  "version" : "3.16",
 ...
}

This change is not reflected in the snap info output (yet).

@stolowski stolowski requested a review from chipaca Aug 14, 2019

@stolowski stolowski added this to the 2.41 milestone Aug 14, 2019

@chipaca
Copy link
Member

left a comment

perfect

@stolowski stolowski requested a review from robert-ancell Aug 14, 2019

@mvo5

mvo5 approved these changes Aug 15, 2019

@mvo5 mvo5 merged commit 86a4c16 into snapcore:master Aug 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.