restart systemd-modules-load.service if config changes modules or modprobe #76

Merged
merged 3 commits into from Nov 12, 2015

Conversation

Projects
None yet
3 participants
Member

chipaca commented Nov 10, 2015

This means adding a module will have effect immediately instead of needing to wait until reboot. Especially important for modules set via oem config.

This is might be in theory thought of as part of the same "restart services on config change" thing we still need to do, but as this is not a service in the snappy sense, the code is quite different.

This fixes lp:1514890.

Member

elopio commented Nov 11, 2015

This requires an integration test. But we still have problems to solve before we can run a suite with a different gadget snap. Can you please write the test in a file called integration-tests/manual-tests.md ?

Contributor

niemeyer commented Nov 11, 2015

LGTM

chipaca added some commits Nov 12, 2015

chipaca added a commit that referenced this pull request Nov 12, 2015

Merge pull request #76 from chipaca/fix-1514890
restart systemd-modules-load.service if config changes modules or modprobe

@chipaca chipaca merged commit 835c5b6 into snapcore:master Nov 12, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.3%) to 65.946%
Details

@chipaca chipaca deleted the chipaca:fix-1514890 branch Dec 8, 2015

zyga added a commit to zyga/snapd that referenced this pull request Nov 7, 2016

Merge pull request #76 from snapcore/drop-old-fs-layout
Drop the alternative to ROOTFS_IS_CORE_SNAP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment