Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interfaces/pulseaudio: adjust to manually connect by default #7631

Merged

Conversation

@jdstrand
Copy link
Contributor

jdstrand commented Oct 18, 2019

Snaps should use audio-playback (and audio-record if they need
recording) instead of pulseaudio. Now that audio-record has been
available since 2.41 and all existing snaps in the snap store that plugs
pulseaudio have been grandfathered to have a snap declaration to
auto-connect pulseaudio, it is time to adjust pulseaudio to manually
connect.

References:

Snaps should use audio-playback (and audio-record if they need
recording) instead of pulseaudio. Now that audio-record has been
available since 2.41 and all existing snaps in the snap store that plugs
pulseaudio have been grandfathered to have a snap declaration to
auto-connect pulseaudio, it is time to adjust pulseaudio to manually
connect.

References:
- https://forum.snapcraft.io/t/upcoming-pulseaudio-interface-deprecation/13418
@zyga
zyga approved these changes Oct 18, 2019
@tom-james-watson

This comment has been minimized.

Copy link

tom-james-watson commented Oct 19, 2019

If a new release is published to the snap store that requests pulse-audio and not audio-playback, will they have grandfathering patch auto-applied?

Just wondering what will happen if I publish a new version of my package before electron-userland/electron-builder#4234 (comment) gets resolved. Thanks!

Copy link
Contributor

stolowski left a comment

LGTM

@jdstrand

This comment has been minimized.

Copy link
Contributor Author

jdstrand commented Oct 23, 2019

If a new release is published to the snap store that requests pulse-audio and not audio-playback, will they have grandfathering patch auto-applied?

Just wondering what will happen if I publish a new version of my package before electron-userland/electron-builder#4234 (comment) gets resolved. Thanks!

The grandfathering happens store side and yes, for existing snaps, this has already been done and snaps don't have to change to add audio-playback and shouldn't regress. Note also, it is fine to specify audio-playback and pulseaudio at the same time and also fine to specify audio-playback on a system with snapd < 2.41 (it, obviously, just won't be connected since it doesn't exist there, but it will install just fine).

The main thing about electron-userland/electron-builder#4234 is that for new snaps without this applied, pulseaudio won't be auto-connected, but they will install just fine. We have a process that people can follow, and if/when someone requests pulseaudio to be auto-connected, we can guide them towards using audio-playback instead until electron-builder is updated.

@jdstrand jdstrand merged commit 7c06135 into snapcore:master Oct 23, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jdstrand

This comment has been minimized.

Copy link
Contributor Author

jdstrand commented Oct 23, 2019

Thanks for the reviews!

@jdstrand jdstrand deleted the jdstrand:pulseaudio-should-manually-connect-now branch Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.