github: port CLA check to Github Actions #8429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhenstridge
force-pushed
the
github-workflow-cla-check
branch
6 times, most recently
from
e06ec25
to
2058414
Compare
jhenstridge
force-pushed
the
github-workflow-cla-check
branch
from
2058414
to
b7764d6
Compare
jhenstridge
force-pushed
the
github-workflow-cla-check
branch
from
1ae8a85
to
901d1d1
Compare
bboozzoo
approved these changes
Apr 6, 2020
jhenstridge
force-pushed
the
github-workflow-cla-check
branch
from
b84ffcc
to
f19df85
Compare
|
@jhenstridge should the CLA check be a separate workflow that runs separately of the remaining tests? This would allow us to restart CLA checks separately. |
This was suggested by @zyga, since it allows the job to be restarted independent of the other workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port the CLA check from Travis over to Github Actions.
I've removed the use of the
TRAVIS_COMMIT_RANGEenvironment variable in the Python script: it turns out we can determine the new commits based on the synthetic merge commit we're asked to test (first parent is the destination branch head, second parent is the proposed branch head).This PR doesn't make the new job a prerequisite for the spread jobs, since that would prevent those jobs from running when it is skipped (or at least once the workflow is enabled for push events).
I've left the Travis CLA check job enabled for now, to allow comparison of the output.