Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootloader/ubootenv: don't panic with an empty uboot env #8771

Merged
merged 1 commit into from May 29, 2020
Merged

bootloader/ubootenv: don't panic with an empty uboot env #8771

merged 1 commit into from May 29, 2020

Conversation

pedronis
Copy link
Collaborator

No description provided.

@pedronis pedronis added the Simple 😃 A small PR which can be reviewed quickly label May 29, 2020
mvo5
mvo5 approved these changes May 29, 2020
View reviewed changes
Copy link
Collaborator

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

anonymouse64
anonymouse64 approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@anonymouse64 anonymouse64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had noticed this when I was working with the uboot env, but never got around to fixing it, thanks for this

@pedronis pedronis merged commit a65fffe into snapcore:master May 29, 2020
@pedronis pedronis deleted the ubootenv-empty-err branch May 29, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyga zyga zyga approved these changes

@mvo5 mvo5 mvo5 approved these changes

@anonymouse64 anonymouse64 anonymouse64 approved these changes

Assignees
No one assigned
Labels
Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
Milestone
No milestone
4 participants
@pedronis @zyga @mvo5 @anonymouse64